Relate Invoice with Order #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
the
Enhancement
GSadee
reviewed
Jun 11, 2021
|
@GSadee UPGRADE file updated 🖖 |
GSadee
reviewed
Jun 11, 2021
|
|
||
| 1. `orderNumber` field on `Sylius\InvoicingPlugin\Entity\Invoice` has been removed and replaced with relation to `Order` entity. | ||
| 1. `Sylius\InvoicingPlugin\Entity\InvoiceInterface::orderNumber` function is left due to easier and smoother upgrades, | ||
| but is also deprecated and will be removed in the `v1.0.0` release. Use `Sylius\InvoicingPlugin\Entity\InvoiceInterface::order` instead. |
There was a problem hiding this comment.
Shouldn't we remove that method earlier than v1.0.0?
There was a problem hiding this comment.
I chose v1.0.0 because I had no better idea which version it should be :D alpha? beta? rc? I think we can rethink that, but also we can just change this decision later, so it does not block the merge 💃
Co-authored-by: Grzegorz Sadowski <[email protected]>
GSadee
approved these changes
Jun 14, 2021
|
Thank you, Mateusz! 🎉 |
SirDomin
added a commit
to Sylius/PayPalPlugin
that referenced
this pull request
Jul 9, 2021
This PR was merged into the 1.0-dev branch. Discussion ---------- Before [this change](Sylius/InvoicingPlugin#226), it was impossible to place the PayPal order from the Payment page, due to some problems with Invoice generation (missing number on order). Therefore, we should require at least SyliusInvoicingPlugin v0.16.0 and release a new version asap 🖖 🚀 Commits ------- 5df3399 Conflict with SyliusInvoicingPlugin below 0.16.0 76dfc7c Fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Sylius/RefundPlugin#306 and Sylius/RefundPlugin#307.
Should be easier to operate on the Invoice with a proper relation rather than just an order number