Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Symfony's dotenv file handling #155

Closed
pamil opened this issue Jan 11, 2019 · 1 comment
Closed

Switch to Symfony's dotenv file handling #155

pamil opened this issue Jan 11, 2019 · 1 comment

Comments

@pamil
Copy link
Contributor

pamil commented Jan 11, 2019

References Sylius/Sylius#10089.
@pamil pamil mentioned this issue Jan 11, 2019
Merged
pamil added a commit to Sylius/Sylius that referenced this issue Jan 13, 2019
@pamil
feature #10089 Switch to Symfony's dotenv file handling (pamil)
10d6b88 
This PR was merged into the 1.2-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.4
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | maybe, but not in the code (Behat configuration, needs some testing)
| Deprecations?   | no
| Related tickets | -
| License         | MIT

See https://symfony.com/doc/current/configuration/dot-env-changes.html for reference.

TODO (after merge):
 - Port this change to Sylius/Sylius-Standard (Sylius/Sylius-Standard#316)
 - Port this change to Sylius/PluginSkeleton (Sylius/PluginSkeleton#155)

<!--
 - Bug fixes must be submitted against the 1.2 or 1.3 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->


Commits
-------

7ed7239 Switch to Symfony's dotenv file handling
@pamil
Copy link
Contributor Author

pamil commented Jan 23, 2019

Fixed by #156.

@pamil pamil closed this as completed Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pamil