Skip to content

Commit

Permalink
refactor #244 [Maintenance] Drop Sylius 1.7 support (GSadee)
Browse files Browse the repository at this point in the history
This PR was merged into the 1.0-dev branch.

Discussion
----------

Associated with #230 

As Sylius 1.7 is already not actively maintained, we need to bump to supported releases as fast as possible and we would like to encourage everyone to upgrade to the latest supported version: Sylius 1.8.

All opinions are appreciated 😃 

Commits
-------

523da79 [Maintenance] Drop Sylius 1.7 support
  • Loading branch information
GSadee authored Jan 15, 2021
2 parents 0e879c0 + 523da79 commit 19e1a32
Show file tree
Hide file tree
Showing 21 changed files with 20 additions and 977 deletions.
18 changes: 2 additions & 16 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
php: [7.4, 7.3]
node: [10.x]
mysql: [5.7, 8.0]
sylius: [1.7.*, 1.8.*]
sylius: [1.8.*]

exclude:
-
Expand Down Expand Up @@ -92,21 +92,7 @@ jobs:
restore-keys: |
${{ runner.os }}-php-${{ matrix.php }}-composer-
-
name: Prepare migrations for Sylius 1.7
if: matrix.sylius == '1.7.*'
run: |
cp etc/sylius17/migrations/* tests/Application/src/Migrations/
cp src/Migrations/* tests/Application/src/Migrations/
sed -i -- 's/Sylius\\RefundPlugin\\Migrations/DoctrineMigrations/g' tests/Application/src/Migrations/*
cp etc/sylius17/bundles.php tests/Application/config/
cp etc/sylius17/doctrine_migrations.yaml tests/Application/config/packages/
cp etc/sylius17/security.yaml tests/Application/config/packages/
rm tests/Application/config/packages//lexik_jwt_authentication.yaml
rm tests/Application/config/routes/sylius_api.yaml
- name: Prepare migrations for Sylius 1.8
if: matrix.sylius == '1.8.*'
- name: Prepare migrations
run: |
composer require sylius-labs/doctrine-migrations-extra-bundle --no-interaction --no-update
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"knplabs/knp-snappy-bundle": "^1.7",
"myclabs/php-enum": "^1.7",
"sylius/resource-bundle": "^1.6",
"sylius/sylius": "^1.7",
"sylius/sylius": "^1.8",
"symfony/messenger": "^4.4"
},
"require-dev": {
Expand Down
58 changes: 0 additions & 58 deletions etc/sylius17/bundles.php

This file was deleted.

3 changes: 0 additions & 3 deletions etc/sylius17/doctrine_migrations.yaml

This file was deleted.

Loading

0 comments on commit 19e1a32

Please sign in to comment.