Update duplicated migrations not to execute if the changes already ex…

…ists in db

.github/workflows/build.yml

@@ -135,23 +135,10 @@ jobs:
                 name: Install JS dependencies
                 run: (cd tests/Application && yarn install)
 
-            -
-                name: Create test application database
-                run: |
-                    (cd tests/Application && bin/console doctrine:database:create -vvv)
-
-            -
-                name: Exclude duplicated migrations
-                if: matrix.sylius != '~1.8.0'
-                run: |
-                    (cd tests/Application && bin/console doctrine:migration:sync-metadata-storage)
-                    (cd tests/Application && bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201130071338' --add)
-                    (cd tests/Application && bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201204071301' --add)
-                    (cd tests/Application && bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201208105207' --add)
-
             -
                 name: Prepare test application database
                 run: |
+                    (cd tests/Application && bin/console doctrine:database:create -vvv)
                     (cd tests/Application && bin/console doctrine:migrations:migrate -n -vvv -q)
 
             -

README.md

@@ -44,22 +44,13 @@ It is used by `KnpSnappyBundle` and can be configured according to [their documm
 
     > Remember to allow community recipes with `composer config extra.symfony.allow-contrib true` or during plugin installation process
 
-2. If you install the plugin on Sylius 1.9 or higher, exclude duplicated migrations:
-
-    ```bash
-    bin/console doctrine:migration:sync-metadata-storage
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201130071338' --add
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201204071301' --add
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201208105207' --add
-    ``` 
-
-3. Apply migration to your database:
+2. Apply migration to your database:
 
     ```bash
     bin/console doctrine:migrations:migrate
     ```
 
-4. Copy Sylius templates overridden in plugin to your templates directory (e.g `templates/bundles/`):
+3. Copy Sylius templates overridden in plugin to your templates directory (e.g `templates/bundles/`):
 
     ```bash
     mkdir -p templates/bundles/SyliusAdminBundle/

UPGRADE.md

@@ -14,15 +14,6 @@
     bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201208105207' --add
     ```
 
-1. If you upgrade also Sylius to 1.9 version, exclude duplicated migrations:
-
-    ```bash
-    bin/console doctrine:migration:sync-metadata-storage
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201130071338' --add
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201204071301' --add
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201208105207' --add
-    ``` 
-
 1. Add traits that enhance Adjustment and Shipment models from Sylius. These traits are not covered by 
 the backward compatibility promise and it will be removed after update Sylius to 1.9. It is a duplication of a logic 
 from Sylius to provide proper adjustments handling.

docs/legacy_installation.md

@@ -6,7 +6,7 @@
     composer require sylius/refund-plugin
     ```
 
-2. Add plugin class and other required bundles to your `AppKernel`:
+1. Add plugin class and other required bundles to your `AppKernel`:
 
     ```php
     $bundles = [
@@ -15,20 +15,20 @@
     ];
     ```
 
-3. Import configuration:
+1. Import configuration:
 
     ```yaml
     imports:
         - { resource: "@SyliusRefundPlugin/Resources/config/app/config.yml" }
     ```
-4. Import routing:
+1. Import routing:
 
     ````yaml
     sylius_refund:
         resource: "@SyliusRefundPlugin/Resources/config/routing.yml"
     ````
 
-5. Configure `KnpSnappyBundle` (if you don't have it configured yet):
+1. Configure `KnpSnappyBundle` (if you don't have it configured yet):
 
     ````yaml
     knp_snappy:
@@ -38,29 +38,20 @@
             options: []
     ````
     
-6. If you install the plugin on Sylius 1.9 or higher, exclude duplicated migrations:
-
-    ```bash
-    bin/console doctrine:migration:sync-metadata-storage
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201130071338' --add
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201204071301' --add
-    bin/console doctrine:migrations:version 'Sylius\RefundPlugin\Migrations\Version20201208105207' --add
-    ``` 
-
-7. Apply migrations to your database:
+1. Apply migrations to your database:
 
     ```bash
     bin/console doctrine:migrations:migrate
     ```
 
-8. Copy Sylius templates overridden in plugin to your templates directory (e.g `templates/bundles/`):
+1. Copy Sylius templates overridden in plugin to your templates directory (e.g `templates/bundles/`):
 
     ```bash
     mkdir -p templates/bundles/SyliusAdminBundle/
     cp -R vendor/sylius/refund-plugin/src/Resources/views/SyliusAdminBundle/* templates/bundles/SyliusAdminBundle/
     ```
 
-9. Clear cache:
+1. Clear cache:
 
     ```bash
     bin/console cache:clear

src/Migrations/Version20201130071338.php

@@ -31,6 +31,11 @@ public function getDescription(): string
 
     public function up(Schema $schema): void
     {
+        $adjustmentTable = $schema->getTable('sylius_adjustment');
+        if ($adjustmentTable->hasColumn('shipment_id')) {
+            return;
+        }
+
         $this->addSql('ALTER TABLE sylius_adjustment ADD shipment_id INT DEFAULT NULL');
         $this->addSql('ALTER TABLE sylius_adjustment ADD CONSTRAINT FK_ACA6E0F27BE036FC FOREIGN KEY (shipment_id) REFERENCES sylius_shipment (id) ON DELETE CASCADE');
         $this->addSql('CREATE INDEX IDX_ACA6E0F27BE036FC ON sylius_adjustment (shipment_id)');

src/Migrations/Version20201204071301.php

@@ -31,6 +31,11 @@ public function getDescription(): string
 
     public function up(Schema $schema): void
     {
+        $adjustmentTable = $schema->getTable('sylius_adjustment');
+        if ($adjustmentTable->hasColumn('details')) {
+            return;
+        }
+
         $this->addSql('ALTER TABLE sylius_adjustment ADD details JSON NOT NULL');
     }