remove redundant route from credit memo

Sylius · Jan 10, 2020 · 67b99b6 · 67b99b6
1 parent d4fd79c
commit 67b99b6
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 68 deletions.
diff --git a/src/Resources/config/admin_routing.yml b/src/Resources/config/admin_routing.yml
@@ -73,13 +73,3 @@ sylius_refund_admin_credit_memo_send:
     methods: [GET]
     defaults:
         _controller: Sylius\RefundPlugin\Action\Admin\SendCreditMemoAction
-
-sylius_refund_admin_order_show_by_number:
-    path: /orders/by-number/{number}
-    methods: [GET]
-    defaults:
-        _controller: Sylius\RefundPlugin\Ui\RedirectToOrderShowAction
-        _sylius:
-            section: admin
-            permission: true
-            alias: refund_plugin
diff --git a/src/Resources/config/app/config.yml b/src/Resources/config/app/config.yml
@@ -65,7 +65,7 @@ sylius_grid:
                 orderNumber:
                     type: twig
                     label: sylius.ui.order
-                    path: order.number
+                    path: .
                     sortable: ~
                     options:
                         template: "@SyliusRefundPlugin/Order/Grid/Field/number.html.twig"

diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -75,11 +75,6 @@
             <argument type="service" id="sylius.manager.order" />
         </service>
 
-        <service id="Sylius\RefundPlugin\Ui\RedirectToOrderShowAction">
-            <argument type="service" id="router" />
-            <argument type="service" id="sylius.repository.order" />
-        </service>
-
         <service id="Sylius\RefundPlugin\Checker\OrderFullyRefundedTotalChecker">
             <argument type="service" id="Sylius\RefundPlugin\Provider\OrderRefundedTotalProvider" />
         </service>

diff --git a/src/Resources/views/Order/Grid/Field/number.html.twig b/src/Resources/views/Order/Grid/Field/number.html.twig
@@ -1 +1 @@
-<a href="{{ path('sylius_refund_admin_order_show_by_number', {'number': data}) }}">#{{ data }}</a>
+<a href="{{ path('sylius_admin_order_show', {'id': data.order.id}) }}">#{{ data.order.number }}</a>
diff --git a/src/Ui/RedirectToOrderShowAction.php b/src/Ui/RedirectToOrderShowAction.php
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<a href="{{ path('sylius_refund_admin_order_show_by_number', {'number': data}) }}">#{{ data }}</a>
		<a href="{{ path('sylius_admin_order_show', {'id': data.order.id}) }}">#{{ data.order.number }}</a>