[RefundPayment] Fixes after static analysis

Sylius · Jun 9, 2021 · 8a526ab · 8a526ab
1 parent 545d719
commit 8a526ab
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/spec/Factory/RefundPaymentFactorySpec.php b/spec/Factory/RefundPaymentFactorySpec.php
@@ -54,13 +54,14 @@ public function it_creates_new_refund_payment(
                 RefundPaymentInterface::STATE_NEW,
                 1
             )
-            ->shouldBeLike(new RefundPayment(
+            ->shouldBeLike(
+                new RefundPayment(
                     $order->getWrappedObject(),
-                1000,
-                'USD',
-                RefundPaymentInterface::STATE_NEW,
-                $paymentMethod->getWrappedObject()
-            )
-        );
+                    1000,
+                    'USD',
+                    RefundPaymentInterface::STATE_NEW,
+                    $paymentMethod->getWrappedObject()
+                )
+            );
     }
 }
diff --git a/src/Entity/RefundPayment.php b/src/Entity/RefundPayment.php
@@ -62,7 +62,7 @@ public function getOrder(): OrderInterface
 
     public function getOrderNumber(): string
     {
-        return $this->getOrder()->getNumber();
+        return (string) $this->getOrder()->getNumber();
     }
 
     public function getAmount(): int

diff --git a/src/Migrations/Version20210609071246.php b/src/Migrations/Version20210609071246.php
@@ -45,7 +45,8 @@ public function down(Schema $schema): void
         $this->addSql('DROP INDEX IDX_EC283EA58D9F6D38 ON sylius_refund_refund_payment');
         $this->addSql('ALTER TABLE sylius_refund_refund_payment ADD order_number VARCHAR(255) CHARACTER SET utf8 NOT NULL COLLATE `utf8_unicode_ci`');
 
-        $this->addSql('
+        $this->addSql(
+            '
             UPDATE sylius_refund_refund_payment
             SET sylius_refund_refund_payment.order_number = (
                 SELECT sylius_order.number FROM sylius_order WHERE sylius_order.id = sylius_refund_refund_payment.order_id