CS fixes

easy-coding-standard.yml

@@ -1,2 +1,6 @@
 imports:
     - { resource: 'vendor/sylius-labs/coding-standard/easy-coding-standard.yml' }
+
+parameters:
+    skip:
+        SlevomatCodingStandard\Sniffs\Commenting\InlineDocCommentDeclarationSniff.MissingVariable: ~

src/Entity/ShipmentInterface.php

@@ -13,8 +13,8 @@
 
 namespace Sylius\RefundPlugin\Entity;
 
-use Sylius\Component\Order\Model\AdjustableInterface;
 use Sylius\Component\Core\Model\ShipmentInterface as BaseShipmentInterface;
+use Sylius\Component\Order\Model\AdjustableInterface;
 
 /**
  * @internal

src/Entity/ShipmentTrait.php

@@ -15,6 +15,7 @@
 
 use Doctrine\Common\Collections\Collection;
 use Sylius\Component\Order\Model\AdjustmentInterface as BaseAdjustmentInterface;
+use Webmozart\Assert\Assert;
 
 /**
  * @internal
@@ -64,6 +65,8 @@ public function getAdjustments(?string $type = null): Collection
     public function addAdjustment(BaseAdjustmentInterface $adjustment): void
     {
         /** @var AdjustmentInterface $adjustment */
+        Assert::isInstanceOf($adjustment, AdjustmentInterface::class);
+
         if ($this->hasAdjustment($adjustment)) {
             return;
         }

src/Migrations/Version20201208105207.php

@@ -56,7 +56,7 @@ public function down(Schema $schema): void
         $this->setDefaultAdjustmentData();
     }
 
-    private function getShippingMethodName(?string $shippingMethodCode)
+    private function getShippingMethodName(?string $shippingMethodCode): ?string
     {
         if ($shippingMethodCode === null) {
             return $shippingMethodCode;
@@ -76,7 +76,10 @@ private function getParsedDetails(array $details): string
             }
         }
 
-        return json_encode($parsedDetails);
+        /** @var string $encodedDetails */
+        $encodedDetails = json_encode($parsedDetails);
+
+        return $encodedDetails;
     }
 
     private function setDefaultAdjustmentData(): void

src/OrderProcessor/OrderTaxesProcessor.php

@@ -94,15 +94,14 @@ private function getTaxZone(OrderInterface $order): ?ZoneInterface
         return $zone ?: $this->defaultTaxZoneProvider->getZone($order);
     }
 
-    private function clearTaxes(BaseOrderInterface $order): void
+    private function clearTaxes(OrderInterface $order): void
     {
         $order->removeAdjustments(AdjustmentInterface::TAX_ADJUSTMENT);
 
         foreach ($order->getItems() as $item) {
             $item->removeAdjustmentsRecursively(AdjustmentInterface::TAX_ADJUSTMENT);
         }
 
-        /** @var OrderInterface $order */
         /** @var ShipmentInterface $shipment */
         foreach ($order->getShipments() as $shipment) {
             $shipment->removeAdjustments(AdjustmentInterface::TAX_ADJUSTMENT);

src/OrderProcessor/ShippingChargesProcessor.php

@@ -20,6 +20,7 @@
 use Sylius\Component\Shipping\Calculator\DelegatingCalculatorInterface;
 use Sylius\Component\Shipping\Calculator\UndefinedShippingMethodException;
 use Sylius\RefundPlugin\Entity\AdjustmentInterface;
+use Sylius\RefundPlugin\Entity\ShipmentInterface;
 use Webmozart\Assert\Assert;
 
 /**
@@ -52,12 +53,14 @@ public function process(BaseOrderInterface $order): void
         // Remove all shipping adjustments, we recalculate everything from scratch.
         $order->removeAdjustments(AdjustmentInterface::SHIPPING_ADJUSTMENT);
 
+        /** @var ShipmentInterface $shipment */
         foreach ($order->getShipments() as $shipment) {
             $shipment->removeAdjustments(AdjustmentInterface::SHIPPING_ADJUSTMENT);
 
             try {
                 $shippingCharge = $this->shippingChargesCalculator->calculate($shipment);
                 $shippingMethod = $shipment->getMethod();
+                Assert::notNull($shippingMethod);
 
                 /** @var AdjustmentInterface $adjustment */
                 $adjustment = $this->adjustmentFactory->createNew();

src/TaxesApplicator/OrderItemUnitsTaxesApplicator.php

@@ -59,6 +59,7 @@ public function apply(OrderInterface $order, ZoneInterface $zone): void
                 continue;
             }
 
+            /** @var OrderItemUnitInterface $unit */
             foreach ($item->getUnits() as $unit) {
                 $taxAmount = $this->calculator->calculate($unit->getTotal(), $taxRate);
                 if (0.00 === $taxAmount) {

src/TaxesApplicator/OrderItemsTaxesApplicator.php

@@ -76,6 +76,7 @@ public function apply(OrderInterface $order, ZoneInterface $zone): void
             $splitTaxes = $this->distributor->distribute($totalTaxAmount, $quantity);
 
             $i = 0;
+            /** @var OrderItemUnitInterface $unit */
             foreach ($item->getUnits() as $unit) {
                 if (0 === $splitTaxes[$i]) {
                     continue;