[Behat][CreditMemo] Scenarios fixes after PR review

Sylius · Jan 23, 2020 · f92af2c · f92af2c
1 parent 76445f2
commit f92af2c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/...res/seeing_details_of_credit_memo.feature → ...es/viewing_details_of_credit_memo.feature b/...res/seeing_details_of_credit_memo.feature → ...es/viewing_details_of_credit_memo.feature
@@ -1,8 +1,8 @@
 @refunds
-Feature: Seeing the details of generated credit memo
+Feature: Viewing details of a credit memo
     In order to be aware of what order units have been refunded
     As an Administrator
-    I want to be able to view details of generated credit memo
+    I want to be able to view details of a credit memo
 
     Background:
         Given the store operates on a single green channel in "United States"
@@ -24,7 +24,7 @@ Feature: Seeing the details of generated credit memo
         And I am logged in as an administrator
 
     @ui @application
-    Scenario: Seeing the details of generated credit memo
+    Scenario: Viewing details of a credit memo issued for a full refund
         Given all units from the order "#00000022" are refunded with "Space money" payment
         When I browse the details of the only credit memo generated for order "#00000022"
         Then it should have sequential number generated from current date
@@ -33,25 +33,24 @@ Feature: Seeing the details of generated credit memo
         And it should be issued from "Rick Sanchez", "Seaside Fwy", "90802" "Los Angeles" in the "United States"
         And it should contain 1 "PHP T-Shirt" product with "10.00" net value, "1.00" tax amount and "11.00" gross value in "USD" currency
         And it should contain 1 "Symfony Mug" product with "17.50" net value, "3.50" tax amount and "21.00" gross value in "USD" currency
-        And its subtotal should be "27.50" in "USD" currency
         And it should have a tax item "US VAT (10%)" with amount "1.00" in "USD" currency
         And it should have a tax item "VAT (20%)" with amount "3.50" in "USD" currency
         And its total should be "32.00" in "USD" currency
 
     @ui @application
-    Scenario: Seeing the details of generated credit memo with partial price
+    Scenario: Viewing details of a credit memo issued for a partial refund
         Given 1st "PHP T-Shirt" product from order "#00000022" has already "$5.00" refunded with "Space money" payment
+        Given the 1st "PHP T-Shirt" product from order "#00000022" already has a refund of "$5.00" with "Space money" payment
         When I browse the details of the only credit memo generated for order "#00000022"
         Then it should have sequential number generated from current date
         And it should be issued in "United States" channel
-        And its subtotal should be "5.00"
         And it should contain 1 "PHP T-Shirt" product with "5.00" net value, "0.50" tax amount and "5.50" gross value in "USD" currency
         And it should have a tax item "US VAT (10%)" with amount "0.50" in "USD" currency
         And its total should be "5.50" in "USD" currency
 
     @ui @application
-    Scenario: Seeing the details of generated credit memo with partial shipment price
-        Given shipment from order "#00000023" has already "$4.50" refunded with "Space money" payment
+    Scenario: Viewing details of a credit memo issued for a partial shipping cost refund
+        Given the "#00000023" order's shipping cost already has a refund of "$4.50" with "Space money" payment
         When I browse the details of the only credit memo generated for order "#00000023"
         Then it should have sequential number generated from current date
         And this credit memo should contain 1 "Galaxy Post" shipment with "4.50" total in "USD" currency

diff --git a/...redit_memo_with_promotion_applied.feature → ...redit_memo_with_promotion_applied.feature b/...redit_memo_with_promotion_applied.feature → ...redit_memo_with_promotion_applied.feature
@@ -1,8 +1,8 @@
 @refunds
-Feature: Seeing the details of generated credit memo for order with the promotion applied
+Feature: Viewing details of a credit memo for order with a promotion applied
     In order to be aware of what order units have been refunded
     As an Administrator
-    I want to be able to view details of generated credit memo
+    I want to be able to view details of a credit memo
 
     Background:
         Given the store operates on a single green channel in "United States"
@@ -23,7 +23,7 @@ Feature: Seeing the details of generated credit memo for order with the promotio
         And I am logged in as an administrator
 
     @ui @application
-    Scenario: Seeing the details of generated credit memo for order with the promotion applied
+    Scenario: Viewing details of a credit memo issued for an order with a promotion applied
         Given all units from the order "#00000022" are refunded with "Space money" payment
         When I browse the details of the only credit memo generated for order "#00000022"
         Then it should have sequential number generated from current date
@@ -32,6 +32,5 @@ Feature: Seeing the details of generated credit memo for order with the promotio
         And it should be issued from "Rick Sanchez", "Seaside Fwy", "90802" "Los Angeles" in the "United States"
         And it should contain 3 "PHP T-Shirt" products with "9.00" net value, "0.90" tax amount and "9.90" gross value in "USD" currency
         And it should contain 1 "PHP T-Shirt" product with "9.01" net value, "0.90" tax amount and "9.91" gross value in "USD" currency
-        And its subtotal should be "36.01" in "USD" currency
         And it should have a tax item "US VAT (10%)" with amount "3.60" in "USD" currency
         And its total should be "39.61" in "USD" currency