Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.0 - creditMemo.taxItems missing #129

Closed
TELLO0815 opened this issue Mar 24, 2019 · 0 comments · Fixed by #173
Closed

v0.7.0 - creditMemo.taxItems missing #129

TELLO0815 opened this issue Mar 24, 2019 · 0 comments · Fixed by #173
Labels
Feature New feature proposals.
Milestone

Comments

@TELLO0815
Copy link

TELLO0815 commented Mar 24, 2019

I was missing billing address too. I tested to v0.7.0.
Just to give a note ...
The .taxItems is still missing.
Like in invoice plugin:
{% for taxItem in invoice.taxItems %}
Its important to have this in the credit memo too. Also all of them and the value.
In most of the counties the rule for credit memo is the same like for the invoice. Means the .taxItems must be clear on the creditMemo.

TELLO

@Zales0123 Zales0123 added the Feature New feature proposals. label Mar 24, 2019
@Zales0123 Zales0123 added this to the v1.0.0 milestone Jun 26, 2019
Zales0123 added a commit that referenced this issue Jan 15, 2020
This PR was merged into the 1.0-dev branch.

Discussion
----------

Fixes #129

<img width="1677" alt="Zrzut ekranu 2020-01-13 o 11 22 49" src="https://user-images.githubusercontent.com/6140884/72323856-f8d06000-36a9-11ea-9e71-a5f1f62853ae.png">
<img width="789" alt="Zrzut ekranu 2020-01-13 o 11 48 56" src="https://user-images.githubusercontent.com/6140884/72323857-f968f680-36a9-11ea-8447-ab71c0a73aa5.png">


Commits
-------

34156fd [Behat][CreditMemo] Update credit memo scenarios by adding tax items
765bed7 [CreditMemo] Add tax items to credit memo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature proposals.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants