Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CreditMemo] Add tax items to credit memo #173

Merged
merged 2 commits into from
Jan 15, 2020
Merged

[CreditMemo] Add tax items to credit memo #173

merged 2 commits into from
Jan 15, 2020

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Jan 14, 2020 •
edited
Loading

Fixes #129

Zrzut ekranu 2020-01-13 o 11 22 49

Zrzut ekranu 2020-01-13 o 11 48 56

@GSadee GSadee added the Feature New feature proposals. label Jan 14, 2020
@GSadee GSadee requested a review from a team as a code owner January 14, 2020 07:46
@GSadee GSadee force-pushed the credit-memo-tax-items branch from f93fc37 to c82cf72 Compare January 14, 2020 07:59
@GSadee GSadee force-pushed the credit-memo-tax-items branch 3 times, most recently from 90db10c to 972e7b1 Compare January 14, 2020 12:42
Zales0123
Zales0123 reviewed Jan 15, 2020
View reviewed changes
src/Generator/TaxItemsGenerator.php Outdated Show resolved Hide resolved
src/Generator/TaxItemsGenerator.php Outdated Show resolved Hide resolved
tests/Behat/Context/Application/CreditMemoContext.php Outdated Show resolved Hide resolved
src/Resources/views/Download/creditMemo.html.twig Show resolved Hide resolved
features/having_credit_memo_generated.feature Show resolved Hide resolved
@Zales0123 Zales0123 added this to the v1.0.0 milestone Jan 15, 2020
@GSadee GSadee force-pushed the credit-memo-tax-items branch 2 times, most recently from 00e3985 to f553416 Compare January 15, 2020 12:54
@GSadee GSadee force-pushed the credit-memo-tax-items branch from f553416 to 765bed7 Compare January 15, 2020 13:00
@Zales0123 Zales0123 merged commit bd17ace into Sylius:master Jan 15, 2020
@Zales0123
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the credit-memo-tax-items branch January 15, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@AdamKasp AdamKasp AdamKasp approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Feature New feature proposals.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

v0.7.0 - creditMemo.taxItems missing
5 participants
@GSadee @Zales0123 @lchrusciel @AdamKasp @Tomanhez