You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Those entities won't have an ID after construction as they those IDs are assigned by doctrine, but at the same time getId/id type-hints for them are too restrictive.
This PR was merged into the 1.0-dev branch.
Discussion
----------
Fixes#189
Commits
-------
2f2c64f Fix getId/id return typehints for entities
56bf2c6 Normalize doctrine fields mappings
Hello,
Those entities won't have an ID after construction as they those IDs are assigned by doctrine, but at the same time
getId
/id
type-hints for them are too restrictive.https://github.com/Sylius/RefundPlugin/blob/master/src/Entity/CreditMemoSequence.php
https://github.com/Sylius/RefundPlugin/blob/master/src/Entity/CustomerBillingData.php
https://github.com/Sylius/RefundPlugin/blob/master/src/Entity/LineItem.php
https://github.com/Sylius/RefundPlugin/blob/master/src/Entity/RefundPayment.php
https://github.com/Sylius/RefundPlugin/blob/master/src/Entity/ShopBillingData.php
https://github.com/Sylius/RefundPlugin/blob/master/src/Entity/TaxItem.php
LineItem
andTaxItem
have bothgetId
andid
methods, butCustomerBillingData
andShopBillingData
doesn't, while they have similar methods schema.I guess spec would need to be changed as well with something like
https://github.com/Sylius/Sylius/blob/master/src/Sylius/Component/Payment/spec/Model/PaymentSpec.php#L27
Other thing that I've noticed, that
LineItem
andTaxItem
id
doctrine definition doesn't haveAUTO
keyword, if it means anything.https://github.com/Sylius/RefundPlugin/blob/master/src/Resources/config/doctrine/LineItem.orm.xml#L6
The text was updated successfully, but these errors were encountered: