Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getId/id return typehints for entities #199

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

diimpp
Copy link
Member

@diimpp diimpp commented Mar 6, 2020

Fixes #189

@diimpp diimpp marked this pull request as ready for review March 6, 2020 14:02
@diimpp diimpp requested a review from a team as a code owner March 6, 2020 14:02
@lchrusciel lchrusciel merged commit bca5377 into Sylius:master Mar 9, 2020
@lchrusciel
Copy link
Member

Thank you, Dmitri! 🥇

@diimpp diimpp deleted the Issue189_nullable_id branch March 9, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong getId type-hint, it should be nullable
2 participants