Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sylius 1.7] locale filter not found #201

Closed
Prometee opened this issue Mar 9, 2020 · 2 comments · Fixed by #203
Closed

[Sylius 1.7] locale filter not found #201

Prometee opened this issue Mar 9, 2020 · 2 comments · Fixed by #203
Labels
Maintenance Configurations, READMEs, releases, etc.

Comments

@Prometee
Copy link

Prometee commented Mar 9, 2020

While testing Sylius 1.7 I encountered an error into the administration on sylius_refund_order_refunds_list route

Unknown "locale" filter. Did you mean "locale_name", "sylius_locale_name", "sylius_locale_country"?

This occurred because of a filter used in vendor/sylius/refund-plugin/src/Resources/views/orderRefunds.html.twig line 29.

I don't know if it was an old Sylius Twig filter or a Twig add-on one, but maybe this filter can be deleted ?

@tuala
Copy link

tuala commented Mar 10, 2020

Yes it should, you can override the template on your project in the mean time (templates/bundles/SyliusRefundPlugin/_header.html.twig for me, l29 of orderRefunds is a th element). I had the same problem on the refund page itself and used "sylius_locale_country" in templates/bundles/SyliusRefundPlugin/_header.html.twig which displays both locale and country name, not 100% sure that's the one to use tho and don't have time to dig right now.

@Zales0123
Copy link
Member

Generally, we should make RefundPlugin compatible with Sylius 1.7, as it is right now based on Sylius 1.5 (which is not maintained anymore 😕)

@Zales0123 Zales0123 added the Maintenance Configurations, READMEs, releases, etc. label Mar 12, 2020
lchrusciel added a commit that referenced this issue Apr 7, 2020
This PR was merged into the 1.0-dev branch.

Discussion
----------

Close #201. According to my tests, it's the only change needed to make this plugin compatible with 1.7

Commits
-------

2fee6b2 Fix 'Unknown "locale" filter' error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants