Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefundPayment is tagged as final while its content depend on the domain #207

Closed
Nek- opened this issue May 20, 2020 · 0 comments · Fixed by #245
Closed

RefundPayment is tagged as final while its content depend on the domain #207

Nek- opened this issue May 20, 2020 · 0 comments · Fixed by #245

Comments

@Nek-
Copy link
Contributor

Nek- commented May 20, 2020

Hello guys,

The refund payment may be complex but you tagged the RefundPayment entity as final. It means that you cancel completely the possibility to use your code for payment refund if the domain needs more than just those data.

It also means that it makes no sense to have a factory building it since it cannot be different than the expected one.

Maybe I'm wrong... And if so, the architecture needs more explanation in documentation 😮 . Otherwise I suggest to just remove this final comment.
@GSadee GSadee mentioned this issue Jan 14, 2021
Merged
lchrusciel added a commit that referenced this issue Jan 15, 2021
@lchrusciel
refactor #245 Remove final tags from resource entities (GSadee)
8c6a95d 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Fixes #207

Commits
-------

5c57d75 Remove final tags from resource entities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove final tags from resource entities GSadee/RefundPlugin
1 participant
@Nek-