Refund list view fails if CreditMemo entity has been overridden #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
Jun 3, 2020
Co-authored-by: Łukasz Chruściel <[email protected]>
lchrusciel
approved these changes
Jun 4, 2020
Nek-
suggested changes
Jun 17, 2020
src/Resources/config/app/config.yml
Outdated
| @@ -62,7 +62,7 @@ sylius_grid: | |||
| driver: | |||
| name: doctrine/orm | |||
| options: | |||
| class: Sylius\RefundPlugin\Entity\CreditMemo | |||
| class: %sylius_refund.model.credit_memo.class% | |||
There was a problem hiding this comment.
AFAIK this parameter is never set inside the plugin.
There was a problem hiding this comment.
I guess it's the SyliusResourceBundle, which sets this parameter, but I'm not sure about that. But the parameter is definitely available in the container.
There was a problem hiding this comment.
There was a problem hiding this comment.
Nek-
approved these changes
Jun 22, 2020
|
Will this pull request ever be merged or should I close it? |
Zales0123
approved these changes
Jan 7, 2021
|
Thank you, Luca, and sorry for makinging it that long 🖖 |
|
No problem, mostly a little reminder is all it takes 🙂 thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.