Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refund list view fails if CreditMemo entity has been overridden #216

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Refund list view fails if CreditMemo entity has been overridden #216

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1ae964
Update config.yml
luca-rath Jun 2, 2020
77b07c8
Update src/Resources/config/app/config.yml
luca-rath Jun 3, 2020
7edc2e5
Update config.yml
luca-rath Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Resources/config/app/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ sylius_grid:
driver:
name: doctrine/orm
options:
class: Sylius\RefundPlugin\Entity\CreditMemo
class: %sylius_refund.model.credit_memo.class%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this parameter is never set inside the plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's the SyliusResourceBundle, which sets this parameter, but I'm not sure about that. But the parameter is definitely available in the container.

Copy link
Contributor

@Nek- Nek- Jun 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I (do not actually) guess no? https://github.com/Sylius/SyliusResourceBundle/search?q=sylius_refund.model.credit_memo.class&unscoped_q=sylius_refund.model.credit_memo.class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic happens here https://github.com/Sylius/SyliusResourceBundle/blob/3464579ed05b199fcd8bc12e5444b36d65d6a4a5/src/Bundle/DependencyInjection/Driver/AbstractDriver.php#L48 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorting:
number: asc
fields:
Expand Down