Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sylius 1.7 again #230

Merged
merged 5 commits into from
Nov 30, 2020
Merged

Support Sylius 1.7 again #230

merged 5 commits into from
Nov 30, 2020

Conversation

Zales0123
Copy link
Member

With the latest v1.0.0-RC.4, we've introduced support for Doctrine Migrations 3.0. However, it required from us also to support only Sylius ^1.8... with the support for Sylius ^1.5 in the previous tag.

I believe it was a mistake. Doing such a big and work-demanding change as migrations version switch together with bumping Sylius requirement by 3 versions can be a pain in the back for a lot of developers using RefundPlugin already.

I think that doing a step backward can improve the developer experience for those, who already use this plugin. Definitely, the next release (hopefully the stable one already 🤞) would support Sylius 1.8 only, so this one is just an intermediate stage. The implementation is not perfect as well but allows us to test 2 versions of Sylius along with 2 versions of PHP and MySQL 💃

I would love to see your opinion 🖖

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Nov 20, 2020
@Zales0123 Zales0123 requested a review from a team as a code owner November 20, 2020 13:55
oallain
oallain approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zales0123

It's great, and I thank you for that 🚀
I put minor comments, but this PR can be merged without if needed.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
tests/Application/src/Migrations/Version20200122082429.php Outdated Show resolved Hide resolved
@diimpp
Copy link
Member

diimpp commented Nov 20, 2020 •
edited
Loading

On off-topic note, I hope stable release won't be done until architectural problems are solve as discusses in #193

GSadee
GSadee reviewed Nov 23, 2020
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
etc/travis/sylius18/bundles.php Outdated Show resolved Hide resolved
@Zales0123 Zales0123 force-pushed the support-sylius-1.7-again branch 2 times, most recently from 44d7d65 to 1cb2604 Compare November 24, 2020 08:40
@Zales0123 Zales0123 force-pushed the support-sylius-1.7-again branch from 1cb2604 to b6b62e0 Compare November 24, 2020 09:02
@alopez-pp
Copy link

Hi, PayPlug team here 👋

We are working closely with Synolia in order to release our first Sylius x PayPlug plugin, we are pretty excited to make it happen! 🚀

I have two questions for you:

  • When will you tag this modification ?
  • Regarding your message "Definitely, the next release (hopefully the stable one already 🤞) would support Sylius 1.8 only", Does this mean that there is no hope at all to get the refund plugin in a stable version for 1.7 ? Can you explain why ?

Thanks !

@GSadee GSadee merged commit dd88749 into Sylius:master Nov 30, 2020
@GSadee
Copy link
Member

GSadee commented Nov 30, 2020

Thanks, Mateusz! 🥇

@Zales0123 Zales0123 deleted the support-sylius-1.7-again branch November 30, 2020 10:36
@Zales0123
Copy link
Member Author

Zales0123 commented Nov 30, 2020 •
edited
Loading

Hi @alopez-pp!

Thank you for your kind message :) As the PR is merged we will release the next tag as soon as possible EDIT: already released https://github.com/Sylius/RefundPlugin/releases/tag/v1.0.0-RC.5.

Regarding the second question. Sylius 1.7 is already not actively maintained for the last 2 weeks, it will get only security fixes for the next months. It's highly recommended to everyone to upgrade to the latest supported 1.8 and, as creators of both Sylius and this plugin, we need to bump to supported releases as fast as possible. I think you understand our perspective 🖖

If you have any more questions, I would be glad to answer them 🚀

@GSadee GSadee mentioned this pull request Jan 14, 2021
Merged
GSadee added a commit that referenced this pull request Jan 15, 2021
@GSadee
refactor #244 [Maintenance] Drop Sylius 1.7 support (GSadee)
19e1a32 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Associated with #230 

As Sylius 1.7 is already not actively maintained, we need to bump to supported releases as fast as possible and we would like to encourage everyone to upgrade to the latest supported version: Sylius 1.8.

All opinions are appreciated 😃 

Commits
-------

523da79 [Maintenance] Drop Sylius 1.7 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez approved these changes

@oallain oallain oallain approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zales0123 @diimpp @alopez-pp @GSadee @lchrusciel @oallain @Tomanhez