Refunding shipments with taxes #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
refunding-shipments-with-taxes
branch
2 times, most recently
from
a3e2a6c to
fdf0a3d
Compare
GSadee
changed the title
arti0090
approved these changes
Jan 14, 2021
AdamKasp
approved these changes
Jan 14, 2021
lchrusciel
added a commit
to Sylius/Sylius
that referenced
this pull request
Jan 14, 2021
This PR was merged into the 1.9-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #12116 and associated with Sylius/RefundPlugin#242 | License | MIT Commits ------- 066364b [Behat] Reproduce error with dirty entity c849cde [OrderProcessor] Fix clearing tax adjustments 2060b09 [Behat] Add different scenario to cover issue with clearing tax adjustments
Tomanhez
reviewed
Jan 15, 2021
| 'Sylius\RefundPlugin\Migrations' => [ | ||
| 'Sylius\Bundle\CoreBundle\Migrations', | ||
| 'Sylius\Bundle\AdminApiBundle\Migrations', | ||
| ], |
There was a problem hiding this comment.
Maybe we should add functional test for this?
There was a problem hiding this comment.
We could, but not in this PR imo
lchrusciel
reviewed
Jan 16, 2021
Comment on lines
+83
to
+87
| $unitTaxAdjustment->setDetails([ | ||
| 'taxRateCode' => $taxRate->getCode(), | ||
| 'taxRateName' => $taxRate->getName(), | ||
| 'taxRateAmount' => $taxRate->getAmount(), | ||
| ]); |
There was a problem hiding this comment.
As previously it seems like an obvious candidate to have keys as consts + creation of this structure could be extracted to separate service
…ustment and making shipment adjustable
GSadee
force-pushed
the
refunding-shipments-with-taxes
branch
2 times, most recently
from
762b948 to
4336015
Compare
lchrusciel
approved these changes
Jan 18, 2021
GSadee
force-pushed
the
refunding-shipments-with-taxes
branch
from
e76b710 to
ce19c38
Compare
lchrusciel
added a commit
to Sylius/Sylius
that referenced
this pull request
Jan 19, 2021
…adee) This PR was merged into the 1.9-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #12116 | License | MIT According to Sylius/RefundPlugin#242 (comment) Commits ------- 60cc71d [Migrations] Use adding SQL instead of query execution
lchrusciel
approved these changes
Jan 19, 2021
| { | ||
| parent::__construct(); | ||
|
|
||
| /** @var ArrayCollection<array-key, BaseAdjustmentInterface> $this->adjustments */ |
There was a problem hiding this comment.
Probably a minor thing, but BaseAdjustmentInterface does not exist in the namespaces
|
Thanks, Grzegorz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #110