Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove final tags from resource entities #245

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Remove final tags from resource entities #245

merged 1 commit into from
Jan 15, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Jan 14, 2021

Fixes #207

@GSadee GSadee added the DX Issues and PRs aimed at improving Developer eXperience. label Jan 14, 2021
@GSadee GSadee requested a review from a team as a code owner January 14, 2021 13:59
@lchrusciel lchrusciel merged commit 8c6a95d into Sylius:master Jan 15, 2021
@lchrusciel
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the remove-final-tag-from-resource-entities branch January 15, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RefundPayment is tagged as final while its content depend on the domain
3 participants
@GSadee @lchrusciel @Zales0123