Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StateResolver\RefundedStateResolver] logic error in checking order payment state #253

Closed
petar-locastic opened this issue Feb 3, 2021 · 0 comments · Fixed by #263
Closed

[StateResolver\RefundedStateResolver] logic error in checking order payment state #253

petar-locastic opened this issue Feb 3, 2021 · 0 comments · Fixed by #263
Labels
Bug Confirmed bugs or bugfixes.

Comments

@petar-locastic
Copy link

In StateResolver\RefundedStateResolver:50, OrderPaymentStates::STATE_REFUNDED === $order->getState() can't be TRUE, and it should be changed to OrderPaymentStates::STATE_REFUNDED === $order->getPaymentState()
@GSadee GSadee mentioned this issue Mar 9, 2021
Merged
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Mar 9, 2021
lchrusciel added a commit that referenced this issue Mar 10, 2021
@lchrusciel
bug #263 Check proper state during resolving order refunded state (GS…
e233082 
…adee)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Fixes #253

Commits
-------

f651c0f Check proper state during resolving order refunded state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check proper state during resolving order refunded state GSadee/RefundPlugin
2 participants
@GSadee @petar-locastic