Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resource factory to create CreditMemo in CreditMemoGenerator #278

Closed
pamil opened this issue Mar 30, 2021 · 1 comment · Fixed by #295
Closed

Use resource factory to create CreditMemo in CreditMemoGenerator #278

pamil opened this issue Mar 30, 2021 · 1 comment · Fixed by #295

Comments

@pamil
Copy link
Contributor

pamil commented Mar 30, 2021

Currently, it's impossible to customise CreditMemo class.
@pamil
Copy link
Contributor Author

pamil commented Mar 30, 2021

It's kinda hard to achieve that since we create CreditMemo through the constructor.

@pamil pamil mentioned this issue Mar 30, 2021
Closed
@GSadee GSadee mentioned this issue May 24, 2021
Merged
pamil added a commit that referenced this issue May 25, 2021
@pamil
refactor #295 [CreditMemo] Refactor creating CreditMemo to use a fact…
ad02c0f 
…ory (GSadee)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Fixes #278

Commits
-------

dc54ca7 [CreditMemo] Refactor creating CreditMemo to use a factory
7e2266e [CreditMemo] Fixes for credit memo factory after PR review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CreditMemo] Refactor creating CreditMemo to use a factory GSadee/RefundPlugin
1 participant
@pamil