[RefundPayment] Make the Refund customization easier #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
easen-customization
branch
from
7e21428 to
6cda314
Compare
GSadee
changed the title
lchrusciel
approved these changes
Jun 24, 2021
Zales0123
reviewed
Jun 24, 2021
| UnitRefundTotalCalculatorInterface $unitRefundTotalCalculator | ||
| ): void { | ||
| $this->beConstructedWith($unitRefundTotalCalculator); | ||
| public function let(RefundUnitsConverterInterface $refundUnitsConverter): void |
There was a problem hiding this comment.
Why not? public is a default one if there is not access modifier specified
Comment on lines
+54
to
+56
| if (isset($unit['full'])) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This is so bad :( I wonder, cannot we just always operate on the actual value? I don't know won't it need a avalanche of changes in other parts of the application, so could possibly be done as an improvement in a separate PR
There was a problem hiding this comment.
I agree, but I didn't want to change the current behaviour, just extract some logic and improve extendability
Zales0123
approved these changes
Jun 24, 2021
|
Thank you, Grzegorz! 🎉 |
lchrusciel
added a commit
to Sylius/Sylius
that referenced
this pull request
Jun 24, 2021
…omization with improvements (AdamKasp, GSadee) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | bases on #12717 and waits for merge Sylius/RefundPlugin#320 | License | MIT Commits ------- 14689d7 Add cookbook about refund customization 3b689aa [Documentation] Add fixes to cookbook about refund customization 95ad5b3 [Documentation] Add fixes to cookbook about refund customization after refactoring factory acd4b2d [Documentation] Add fixes to cookbook about refund customization after refactoring creator 1e1947e [Documentation] Minor fix to cookbook about refund customization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.