Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][Refund] Add cookbook about refund customization with improvements #12748

Merged

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Jun 24, 2021

Q A
Branch? 1.9
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets bases on #12717 and waits for merge Sylius/RefundPlugin#320
License MIT

@GSadee GSadee added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jun 24, 2021
@GSadee GSadee requested a review from a team as a code owner June 24, 2021 06:16
@GSadee GSadee force-pushed the docs-cookbook-refund-customization-improvements branch 2 times, most recently from be5fdb1 to 454d514 Compare June 24, 2021 09:38
@GSadee GSadee force-pushed the docs-cookbook-refund-customization-improvements branch from 454d514 to acd4b2d Compare June 24, 2021 09:39
@GSadee GSadee changed the title [WIP][Documentation][Refund] Add cookbook about refund customization with improvements [Documentation][Refund] Add cookbook about refund customization with improvements Jun 24, 2021
docs/cookbook/payments/custom-field-on-refund-payment.rst Outdated Show resolved Hide resolved
docs/cookbook/payments/custom-field-on-refund-payment.rst Outdated Show resolved Hide resolved
use Symfony\Component\Messenger\MessageBusInterface;
use Webmozart\Assert\Assert;

final class RefundPaymentProcessManager implements UnitsRefundedProcessStepInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sad, we cannot decorate it or override some smaller services :( Perhaps we should thing about separating some concepts from the original handler to other services

.. code-block:: bash

mkdir -p templates/bundles/SyliusRefundPlugin/Order/Admin
cp vendor/sylius/refund-plugin/src/Resources/views/Order/Admin/_refundPayments.html.twig templates/bundles/SyliusRefundPlugin/Order/Admin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, it's a clue for us, that maybe we could throw some UI event there 🚀

@GSadee GSadee force-pushed the docs-cookbook-refund-customization-improvements branch from e8ef687 to 1e1947e Compare June 24, 2021 12:00
@lchrusciel lchrusciel merged commit a77ca29 into Sylius:1.9 Jun 24, 2021
@lchrusciel
Copy link
Member

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the docs-cookbook-refund-customization-improvements branch June 24, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants