Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to a more meaningful message in factory exception #322

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Change to a more meaningful message in factory exception #322

merged 1 commit into from
Jun 29, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Jun 29, 2021

According to: #321 (review)

@GSadee GSadee added the DX Issues and PRs aimed at improving Developer eXperience. label Jun 29, 2021
@GSadee GSadee requested a review from a team as a code owner June 29, 2021 14:26
@lchrusciel lchrusciel merged commit de9384c into Sylius:master Jun 29, 2021
@lchrusciel
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the refactor-factory-message branch June 29, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GSadee @lchrusciel