Minor improvements for RefundFactory and RefundPaymentFactory #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
factory-improvements
branch
from
e5e7bd9 to
31aed15
Compare
GSadee
force-pushed
the
factory-improvements
branch
from
31aed15 to
8753031
Compare
lchrusciel
reviewed
Jun 29, 2021
| @@ -27,6 +27,11 @@ public function __construct(string $className) | |||
| $this->className = $className; | |||
| } | |||
|
|
|||
| public function createNew(): RefundPaymentInterface | |||
| { | |||
| throw new \InvalidArgumentException('This object is not default constructable.'); | |||
There was a problem hiding this comment.
Suggested change
| throw new \InvalidArgumentException('This object is not default constructable.'); | |
| throw new \InvalidArgumentException('This object is not constructable by default.'); |
or
Suggested change
| throw new \InvalidArgumentException('This object is not default constructable.'); | |
| throw new \InvalidArgumentException('This object is not constructable without any arguments.'); |
or
Suggested change
| throw new \InvalidArgumentException('This object is not default constructable.'); | |
| throw new \InvalidArgumentException('Default creation method is forbidden for this object. Use `createWithData` instead.'); |
lchrusciel
approved these changes
Jun 29, 2021
|
Thanks, Grzegorz! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Jun 29, 2021
…n (GSadee) This PR was merged into the 1.0-dev branch. Discussion ---------- According to: #321 (review) Commits ------- 0045e1c Change to a more meaningful message in factory exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.