Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Credit memo order relation #171

Closed
wants to merge 2 commits into from

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Jan 8, 2020

Add a relation between order and credit memo as a first step to have easily navigation between refund/credit memo and order.
replaced by #172

@AdamKasp AdamKasp requested a review from a team as a code owner January 8, 2020 14:32
@AdamKasp AdamKasp force-pushed the credit-memo-order-relation branch from e235c98 to cc88af7 Compare January 9, 2020 09:02
src/Resources/config/admin_routing.yml Outdated Show resolved Hide resolved
src/Resources/config/shop_routing.yml Outdated Show resolved Hide resolved
@@ -12,3 +12,6 @@ doctrine:
charset: UTF8

url: '%env(resolve:DATABASE_URL)%'
orm:
resolve_target_entities:
Sylius\Component\Core\Model\OrderInterface: Sylius\Component\Core\Model\Order
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add it here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, it was not working without... I was doing a quick PoC so I've added it and decided to resolve it later. @AdamKasp now is "later" 😄

@AdamKasp AdamKasp force-pushed the credit-memo-order-relation branch 2 times, most recently from 0fc85cf to fb3434d Compare January 10, 2020 11:04
@AdamKasp AdamKasp force-pushed the credit-memo-order-relation branch from fb3434d to a48ffdc Compare January 10, 2020 14:31
@AdamKasp AdamKasp closed this Jan 13, 2020
GSadee added a commit that referenced this pull request Jan 14, 2020
…and refund page - order (Zales0123, AdamKasp)

This PR was merged into the 1.0-dev branch.

Discussion
----------

based on #171 
I added breadcrumbs to Credit Memo, fixed breadcrumbs on refunds page, and I deleted redundant route with service from Credit memo index page 

refund page:
![Screenshot 2020-01-13 at 15 54 01](https://user-images.githubusercontent.com/29897151/72265592-0a1f5b00-361d-11ea-8f7e-7abf443d4601.png)

credit memo page:
![Screenshot 2020-01-13 at 15 54 26](https://user-images.githubusercontent.com/29897151/72265610-13a8c300-361d-11ea-8c4b-e4636419e2b8.png)


Commits
-------

63842d4 Change order number to order relation and use it
00c6a35 Add breadcrumb for credit memo, fix refund breadcrumb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants