Update phpspec to ^6.0 version #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nek-
changed the title
Nek-
force-pushed
the
feature/fix-php74-forbidden
branch
from
77ca9b7 to
e6fdc50
Compare
Closed
Problem ------- phpspec was set in version ^4. This version was not compatible with PHP 7.4. So if you have the latest version of PHP on your computer you cannot develop on this plugin. And the upgrade was blocking because of another dependency. Solution -------- Update phpspec to ^6 version. Change phpspec-code-coverage to the friends-of-phpspec version which allows us to use phpspec ^6.
Nek-
force-pushed
the
feature/fix-php74-forbidden
branch
from
e6fdc50 to
a689354
Compare
|
Closing as it has been done in #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
phpspec was set in version ^4. This version was not compatible with
PHP 7.4. So if you have the latest version of PHP on your computer you
cannot develop on this plugin.
And the upgrade was blocking because of another dependency.
Solution
Update phpspec to ^6 version. Change phpspec-code-coverage to the
friends-of-phpspec version which allows us to use phpspec ^6.
Bonus
Add php 7.4 on travis ci.