Remove wrong factory from configuration #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- The RefundFactory is not a factory designed to be use in sylius resources. As a side effect it generates invalid services and may fail. Solution -------- Removing the factory configuration. Since it generates wrong service configuration, it's probably not used anywere.
Nek-
force-pushed
the
fix/wrong-factory-usage
branch
from
ee71c40 to
45be5fc
Compare
|
Can be closed as it is replaced by #223 |
|
Closing in favour of #223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The RefundFactory is not a factory designed to be used in sylius resources. As a side effect it generates invalid services and may fail.
Solution
Removing the factory configuration. Since it generates wrong service configuration, it's probably not used anywhere.
Fix #186