Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up Symfony Messenger requirement #235

Closed
wants to merge 1 commit into from
Closed

Conversation

loevgaard
Copy link
Contributor

No reason to restrict the Symfony Messenger component

No reason to restrict the Symfony Messenger component
@loevgaard loevgaard requested a review from a team as a code owner December 10, 2020 10:41
@Zales0123 Zales0123 added the Maintenance Configurations, READMEs, releases, etc. label Dec 15, 2020
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering shouldn't we explicitly specify messenger version in our builds to make a conscious check of this compatibility 🤔 Still, as far as I see, on some builds 4.4 version is installed, on some 5.2, so it should be safe enough to go 🖖

Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, in fact, it's not that easy :D We didn't require symfony/messenger on Sylius 1.7, but we do on Sylius 1.8... and we require 4.4 version :/ which means, we should wait for the support of this version on sylius/sylius itself

@loevgaard
Copy link
Contributor Author

@Zales0123: I don't see why we can't have a ^4.4 || ^5.0 on this requirement. Why would that ever conflict with sylius/sylius?

@Zales0123
Copy link
Member

The conflict is not explicit, we still would be able to use symfony/messenger:^4.4, but we will never be allowed to use ^5.0 with Sylius 1.8 (which, btw, is the only actively supported version now).

Zrzut ekranu 2020-12-18 o 12 53 43

That's why we would not be able to test the build with symfony/messenger:^5.0 and be sure it works 🚀

@loevgaard
Copy link
Contributor Author

I understand, Mateusz :| Hoping for SF5 support 🤞

@GSadee
Copy link
Member

GSadee commented Feb 18, 2021

Closing in favour of #254

@GSadee GSadee closed this Feb 18, 2021
@loevgaard loevgaard deleted the patch-1 branch February 18, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants