-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Up Symfony Messenger requirement #235
Conversation
No reason to restrict the Symfony Messenger component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering shouldn't we explicitly specify messenger version in our builds to make a conscious check of this compatibility 🤔 Still, as far as I see, on some builds 4.4 version is installed, on some 5.2, so it should be safe enough to go 🖖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, in fact, it's not that easy :D We didn't require symfony/messenger on Sylius 1.7, but we do on Sylius 1.8... and we require 4.4 version :/ which means, we should wait for the support of this version on sylius/sylius
itself
@Zales0123: I don't see why we can't have a |
I understand, Mateusz :| Hoping for SF5 support 🤞 |
Closing in favour of #254 |
No reason to restrict the Symfony Messenger component