Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pdf] set translation credit memo locale #250

Merged
merged 1 commit into from
Jan 29, 2021
+17 −17
Merged

[Pdf] set translation credit memo locale #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions src/Resources/views/Download/creditMemo.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<img src="https://demo.sylius.com/assets/shop/img/logo.png" style="width:300px;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, https://demo.sylius.com/assets/shop/img/logo.png

</td>
<td>
{{ 'sylius_refund.ui.issued_at'|trans }}: {{ creditMemo.issuedAt|date('Y-m-d H:i:s') }}<br>
{{ 'sylius_refund.ui.issued_at'|trans([], 'messages', creditMemo.localeCode) }}: {{ creditMemo.issuedAt|date('Y-m-d H:i:s') }}<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about extraction this creditMemo.localeCode to a variable, instead of copying it 17 times :D?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think if it makes any difference :D this way we know every translation gets credit memo locale code.

</td>
</tr>
</table>
Expand All @@ -45,7 +45,7 @@
<table>
<tr>
<td>
{{ 'sylius_refund.ui.buyer'|trans }}<br/>
{{ 'sylius_refund.ui.buyer'|trans([], 'messages', creditMemo.localeCode) }}<br/>
<strong>{{ from.fullName }} </strong><br/>
{% if from.company %}{{ from.company }}<br/>{% endif %}
{{ from.street }}<br/>
Expand All @@ -55,7 +55,7 @@
</td>
<td>
{% if to != null %}
{{ 'sylius_refund.ui.seller'|trans }}<br/>
{{ 'sylius_refund.ui.seller'|trans([], 'messages', creditMemo.localeCode) }}<br/>
{% if to.company %}<strong>{{ to.company }}</strong><br/>{% endif %}
{% if to.street %}{{ to.street }}<br/>{% endif %}
{% if to.city %}{{ to.city }}<br/>{% endif %}
Expand All @@ -72,19 +72,19 @@
{% endif %}

<tr class="number">
<td colspan="9">{{ 'sylius_refund.ui.credit_memo'|trans }} #{{ creditMemo.number }}</td>
<td colspan="9">{{ 'sylius_refund.ui.credit_memo'|trans([], 'messages', creditMemo.localeCode) }} #{{ creditMemo.number }}</td>
</tr>

<tr class="heading">
<td>{{ 'sylius_refund.ui.no'|trans }}</td>
<td>{{ 'sylius.ui.name'|trans }}</td>
<td>{{ 'sylius.ui.quantity'|trans }}</td>
<td>{{ 'sylius_refund.ui.unit_net_price'|trans }}</td>
<td>{{ 'sylius_refund.ui.net_value'|trans }}</td>
<td>{{ 'sylius_refund.ui.tax_rate'|trans }}</td>
<td>{{ 'sylius_refund.ui.tax_amount'|trans }}</td>
<td>{{ 'sylius_refund.ui.gross_value'|trans }}</td>
<td>{{ 'sylius.ui.currency'|trans }}</td>
<td>{{ 'sylius_refund.ui.no'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius.ui.name'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius.ui.quantity'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius_refund.ui.unit_net_price'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius_refund.ui.net_value'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius_refund.ui.tax_rate'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius_refund.ui.tax_amount'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius_refund.ui.gross_value'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius.ui.currency'|trans([], 'messages', creditMemo.localeCode) }}</td>
</tr>

{% for item in creditMemo.lineItems %}
Expand All @@ -103,17 +103,17 @@

<tr class="total">
<td colspan="6"></td>
<td>{{ 'sylius.ui.total'|trans }}:</td>
<td>{{ 'sylius.ui.total'|trans([], 'messages', creditMemo.localeCode) }}:</td>
<td>{{ '%0.2f'|format(creditMemo.total/100) }}</td>
<td>{{ creditMemo.currencyCode }}</td>
</tr>

{% if creditMemo.taxItems|length > 0 %}
<tr class="heading">
<td colspan="6"></td>
<td>{{ 'sylius_refund.ui.tax_rate'|trans }}</td>
<td>{{ 'sylius_refund.ui.tax_amount'|trans }}</td>
<td>{{ 'sylius.ui.currency'|trans }}</td>
<td>{{ 'sylius_refund.ui.tax_rate'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius_refund.ui.tax_amount'|trans([], 'messages', creditMemo.localeCode) }}</td>
<td>{{ 'sylius.ui.currency'|trans([], 'messages', creditMemo.localeCode) }}</td>
</tr>

{% for item in creditMemo.taxItems %}
Expand Down