Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Upgrade PHPUnit package #283

Merged
merged 1 commit into from
Apr 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@

/tests/Application/yarn.lock

.env.test

Comment on lines -13 to -14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed? This file is not part of this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, but since I changed something in .gitignore file, I wanted to fix and delete a file that shouldn't be there as we have env files only in test application directory

phpspec.yml

/.phpunit.result.cache
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"phpspec/phpspec": "^6.0",
"phpstan/phpstan": "0.12.29",
"phpstan/phpstan-webmozart-assert": "0.12.6",
"phpunit/phpunit": "^8.5",
"phpunit/phpunit": "^9.5",
"sylius-labs/coding-standard": "^3.2",
"symfony/browser-kit": "^4.4 || ^5.2",
"symfony/debug-bundle": "^4.4 || ^5.2",
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/TemporaryFileManagerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ function it_removes_file_from_base_directory(): void
$fileManager->createWithContent('file-to-remove.txt', 'test file content');
$fileManager->remove('file-to-remove.txt');

$this->assertFileNotExists(sys_get_temp_dir().'/file-to-remove.txt');
$this->assertFileDoesNotExist(sys_get_temp_dir().'/file-to-remove.txt');
}
}