Add update page with headers #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Sep 18, 2024
•
loic425
commented
loic425
commented
Sep 18, 2024
src/BootstrapAdminUi/templates/shared/crud/update/content/header/breadcrumbs.html.twig
Show resolved
Hide resolved
loic425
commented
Sep 18, 2024
| @@ -2,9 +2,14 @@ | |||
|
|
|||
| {% set configuration = hookable_metadata.context.configuration %} | |||
|
|
|||
| {% set index_url = sylius_generate_redirect_path(app.request.headers.get('referer')|default(path( | |||
| {#{% set index_url = sylius_generate_redirect_path(app.request.headers.get('referer')|default(path(#} | |||
There was a problem hiding this comment.
we don't have the sylius_generate_redirect_path that should be added to Twig Extra.
diimpp
approved these changes
Sep 18, 2024
| @@ -0,0 +1,34 @@ | |||
| {% from '@SyliusBootstrapAdminUi/shared/helper/breadcrumbs.html.twig' import breadcrumbs %} | |||
There was a problem hiding this comment.
General thought, many templates are almost identical between create/update pages, maybe some of them can be moved to /shared/crud/common/content/header/breadcrumbs and re-used by defining few variables
| @@ -0,0 +1,18 @@ | |||
| {% import '@SyliusBootstrapAdminUi/shared/helper/header.html.twig' as header %} | |||
|
|
|||
| {% if hookable_metadata.context.metadata is defined and hookable_metadata.context.configuration is defined %} | |||
There was a problem hiding this comment.
Once most of the UI will be done. we should review templates for repeatable boilerplace code and make some DX improvements to TwigHooks and other packages to cleanup templates
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.