Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Platform.sh template #1031

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

rhubinak
Copy link
Contributor

@rhubinak rhubinak commented Oct 2, 2024

Missing sodium PHP extension results in an inability to build the the project on platform.sh

      Found a `composer.json`, installing dependencies.
        W: Installing dependencies from lock file (including require-dev)
        W: Verifying lock file contents can be installed on current platform.
        W: Your lock file does not contain a compatible set of packages. Please run composer update.
        W: 
        W:   Problem 1
        W:     - lcobucci/jwt is locked to version 4.3.0 and an update of this package was not requested.
        W:     - lcobucci/jwt 4.3.0 requires ext-sodium * -> it is missing from your system. Install or enable PHP's sodium extension.
        W:   Problem 2
        W:     - lcobucci/jwt 4.3.0 requires ext-sodium * -> it is missing from your system. Install or enable PHP's sodium extension.
        W:     - lexik/jwt-authentication-bundle v2.17.0 requires lcobucci/jwt ^3.4|^4.0 -> satisfiable by lcobucci/jwt[4.3.0].
        W:     - lexik/jwt-authentication-bundle is locked to version v2.17.0 and an update of this package was not requested.
        W: 
        W: To enable extensions, verify that they are enabled in your .ini files:
        W:     - /etc/php/8.3/cli/php.ini
        W: You can also run `php --ini` in a terminal to see which files are used by PHP in CLI mode.
        W: Alternatively, you can run Composer with `--ignore-platform-req=ext-sodium` to temporarily ignore these required extensions.
      
      E: Error building project: `composer` could not be run.

    E: Error: Unable to build application, aborting.

This will fix it resulting in a successful build.

@rhubinak rhubinak requested review from a team as code owners October 2, 2024 10:16
@TheMilek
Copy link
Member

TheMilek commented Dec 5, 2024

Hi @rhubinak!

Could you please provide the exact version of Sylius you are using? 🤔
I tried both 1.13 and 1.14, but couldn’t reproduce the issue.

Thanks in advance! 🍻

@TheMilek TheMilek force-pushed the fix-psh-template-sodium branch from f610cf8 to 4fe8787 Compare December 6, 2024 09:17
@TheMilek
Copy link
Member

TheMilek commented Dec 6, 2024

Hey!

After further investigation, I found that the issue lies with the lcobucci/jwt dependency, which is version 4.0.4 in my case. It seems something may have bumped it, but I couldn’t identify any conflict or anything else that might have caused it 🤔.

Nonetheless, after discussing with the team, we’ve decided to proceed with this PR anyway, as it appears we’ll need sodium in Sylius 2.0. I’ve also opened two additional PRs with a co-author, of course 😅.
Thank you very much for your effort 🥇

@GSadee GSadee merged commit 721f2af into Sylius:1.13 Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants