Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to gulp 4 #228

Merged
merged 2 commits into from
May 23, 2018
Merged

Upgrade to gulp 4 #228

merged 2 commits into from
May 23, 2018

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented May 22, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no?
Deprecations? no
Related tickets Sylius/Sylius#9405
License MIT

Upgrade to gulp 4

Use gulpfile.babel.js so that we can write in ES2015+ 🎉

/cc @pamil

teohhanhui added 2 commits May 22, 2018 14:34
@teohhanhui
Upgrade to gulp 4
b5b615b 
Use gulpfile.babel.js so that we can write in ES2015+
@teohhanhui
Fix loading of LiipImagineBundle routing file
0df8bac
@teohhanhui
Copy link
Contributor Author

And with this, Travis is green again. 💚 🎉

@pamil pamil merged commit 350c2a6 into Sylius:master May 23, 2018
@pamil
Copy link
Contributor

pamil commented May 23, 2018

Thank you, Teoh! 🎉

@teohhanhui teohhanhui mentioned this pull request Jun 1, 2018
Merged
@teohhanhui teohhanhui deleted the upgrade/gulp-4 branch June 1, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teohhanhui @pamil