Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ErrorHandler][FOSRestBundle] Unable to find template "" (looked into: ...) #389

Closed
wants to merge 1 commit into from

Conversation

Prometee
Copy link
Contributor

See FriendsOfSymfony/FOSRestBundle#1853 for explanations.

@Prometee Prometee requested a review from a team as a code owner March 24, 2020 19:20
@lchrusciel lchrusciel added the Bug label Mar 25, 2020
@igormukhingmailcom
Copy link

@lchrusciel, this bugfix is very useful. I had tons of Unable to find template "" (looked into: ...) exceptions last month or so and looks like this PR fixing it (I haven't tested by myself, but it should I guess).

Also, I believe zones should be added to ShopApiPlugin to https://github.com/Sylius/ShopApiPlugin/blob/master/tests/Application/config/packages/fos_rest.yaml and README.md

Related hints: https://gist.github.com/igormukhingmailcom/3196a8cdf87a5c2ac18bac8287034880#3-unable-to-find-template--looked-into-

@lchrusciel lchrusciel closed this Apr 15, 2020
@lchrusciel lchrusciel reopened this Apr 15, 2020
@lchrusciel
Copy link
Member

We need a green build to have it merged

@Prometee
Copy link
Contributor Author

Prometee commented Apr 15, 2020

@lchrusciel the failed build seems to not be related to the PR, isn't it ? Need a rebase ?

@Prometee
Copy link
Contributor Author

@igormukhingmailcom I agree, I also add it for my own project with ShopApiPlugin enable.

@lchrusciel
Copy link
Member

We need #394 to wait for

@igormukhingmailcom
Copy link

Also, it would be nice if this PR title will be changed to something like Unable to find template "" (looked into: ...) - that way it can be googled more easier I believe

@lchrusciel lchrusciel closed this Apr 16, 2020
@lchrusciel lchrusciel reopened this Apr 16, 2020
@Prometee Prometee changed the title Avoid Template missing when error happens [ErrorHandler][FOSRestBundle] Unable to find template "" (looked into: ...) Apr 16, 2020
@lchrusciel
Copy link
Member

Hey Francis, could you rebase this PR?

@Prometee
Copy link
Contributor Author

Prometee commented May 18, 2020

Hi @lchrusciel ! To the master branch or another branch ?

@Prometee Prometee force-pushed the patch-2 branch 2 times, most recently from a80bf55 to 52c539c Compare May 18, 2020 11:08
@lchrusciel
Copy link
Member

unfortunately, build is still failing :( Can you investigate it why?

@pamil pamil changed the base branch from master to 1.7 June 8, 2020 15:40
@pamil
Copy link
Contributor

pamil commented Jun 8, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-2" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil closed this Jun 9, 2020
@pamil pamil reopened this Jun 9, 2020
@Prometee
Copy link
Contributor Author

Thanks you very much @pamil !
Can you relaunch the build, I don't know why it reach a timeout, I run all travis scripts locally with success so it should be ok.

@Prometee Prometee force-pushed the patch-2 branch 4 times, most recently from f936a47 to a8f6dcc Compare October 8, 2020 14:13
@lchrusciel
Copy link
Member

There is a possibility, that error occurs due to high amount of versions to resolve. I hope switch to composer v2 will solve this issue partially. Let's see after #434 merge

@clem21
Copy link

clem21 commented Dec 2, 2020

Hi Francis,
I checkout your PR and rebase here #448 yours is going to be closed

@Prometee Prometee force-pushed the patch-2 branch 2 times, most recently from ac60652 to 9a70331 Compare December 2, 2020 16:46
@Prometee Prometee changed the base branch from 1.7 to master December 2, 2020 16:59
@Prometee
Copy link
Contributor Author

Prometee commented Dec 2, 2020

@clem21 Thank you but it's kind of useless and make a duplicate.

@lchrusciel as the master branch has a failed build, this PR cannot be green.

@lchrusciel
Copy link
Member

Hey @Prometee, I've asked @clem21 for some help here. Let's see if we can fix the main build and finally make this PR land in the core ;)

@Prometee Prometee force-pushed the patch-2 branch 2 times, most recently from b3962a8 to 3abaa7b Compare December 10, 2020 14:16
@Prometee Prometee force-pushed the patch-2 branch 2 times, most recently from ae9cf0a to 1900359 Compare December 18, 2020 14:39
@Prometee Prometee changed the base branch from master to 1.8 January 20, 2021 17:11
@Zales0123
Copy link
Member

I think it can be closed, thank you 🖖

@Zales0123 Zales0123 closed this Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants