[Maintenance] Remove php platform from composer #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
reviewed
Oct 30, 2020
| @@ -39,7 +39,7 @@ jobs: | |||
|
|
|||
| - echo "memory_limit=4096M" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini | |||
|
|
|||
| - composer self-update --1 | |||
| - composer self-update --preview | |||
There was a problem hiding this comment.
I kept preview to have the newest versions, sometimes not stable even. We had it before v2 was announced, but I don't have a strong opinion about it. But if we will change it, I would go with --stable
| use Doctrine\DBAL\Schema\Schema; | ||
| use Doctrine\Migrations\AbstractMigration; | ||
|
|
||
| final class Version20200916093101 extends AbstractMigration |
There was a problem hiding this comment.
Shoudn't it be loaded automatically from the CoreBundle?
There was a problem hiding this comment.
It is opened to 1.7, where we don't have new migrations yet. During upmerge it should be removed
Zales0123
approved these changes
Oct 30, 2020
|
Thank you, Łukasz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the platform from the composer to let flex detect the current environment based on used CLI PHP. In addition, I've added composer v2
Replacecment for #434