Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auth for LiipImagineBundle controllers #580

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Disable auth for LiipImagineBundle controllers #580

merged 1 commit into from
Jun 26, 2021

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jun 21, 2021

Ref: https://twitter.com/mbabker/status/1405962888792231939?s=21 and liip/LiipImagineBundle#1383

Most apps don't need authenticated user info when resolving images, so we can sanely disable the security authentication for these routes.

@mbabker mbabker requested a review from a team as a code owner June 21, 2021 15:51
@lchrusciel lchrusciel merged commit f2fdbd7 into Sylius:1.10 Jun 26, 2021
@lchrusciel
Copy link
Contributor

Thanks, Michael! 🎉

@mbabker mbabker deleted the patch-1 branch August 30, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants