Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing polishsymfonycommunity/symfony-mocker-container dependency #633

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Add missing polishsymfonycommunity/symfony-mocker-container dependency #633

merged 2 commits into from
Dec 9, 2021

Conversation

jakubtobiasz
Copy link
Contributor

Sylius 1.10.6 release has broken running the app based on the Sylius-Standard in a test environment. It's caused by moving "polishsymfonycommunity/symfony-mocker-container" to require-dev. polishsymfonycommunity/symfony-mocker-container is no longer being downloaded so it throws error because in test env it is used in src/Kernel.php.

@jakubtobiasz jakubtobiasz requested a review from a team as a code owner December 8, 2021 17:04
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jakub, thanks a lot for your contribution.

If I see correctly, the PR is failing due to this class: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/ApiBundle/EventSubscriber/KernelRequestEventSubscriber.php

Can you debug it and fix the build? I assume, that following this upgrade: https://github.com/Sylius/Sylius/blob/master/UPGRADE-API-1.10.md#upgrade-from-v1100-to-v1101 should do the trick

@jakubtobiasz
Copy link
Contributor Author

jakubtobiasz commented Dec 9, 2021

@lchrusciel I've enabled Sylius API in services_test.yaml. I think it's the best place because we achieve passed tests along with Sylius API disabled by default in an app.

I've run all tests on my fork and every one passed.

edit:
By the way I'd like to mention I've created a similar PR for PluginSkeleton Sylius/PluginSkeleton#300.

@lchrusciel lchrusciel added the Bug label Dec 9, 2021
@lchrusciel lchrusciel merged commit 5e3d5df into Sylius:1.10 Dec 9, 2021
@lchrusciel
Copy link
Member

Thanks, Jakub! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants