-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintenance] Fix build & prepare it for Sylius v1.11 #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
approved these changes
Dec 31, 2021
lchrusciel
force-pushed
the
fix-build
branch
3 times, most recently
from
January 11, 2022 15:25
65939a0
to
dc630d9
Compare
…n payum to support dbal v3
lchrusciel
force-pushed
the
fix-build
branch
5 times, most recently
from
January 12, 2022 16:00
e0f47e6
to
0e31351
Compare
lchrusciel
force-pushed
the
fix-build
branch
2 times, most recently
from
January 13, 2022 08:36
99789cb
to
8fd1da6
Compare
This change was the simplest scenario for single scecnario failing. This scenario was failing only in UI context(while working fine in API). The problem didn't exist when scenarios where run locally or just in separate step of GitHub Action. Instead of commiting more time for the investigation, I've decided to split the execution.
loic425
approved these changes
Jan 13, 2022
GSadee
approved these changes
Jan 14, 2022
Thank you, Łukasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content of PR:
json_array
withjson
type as requested by the deprecation Sylius#13214The build is finally green, but TBH I'm mindblown with the strangeness of errors. If anyone would like to solve them better, be my guests.
For the two last issues I've alse left comments in commits for future understanding of problems