Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Fix build & prepare it for Sylius v1.11 #647

Merged
merged 7 commits into from
Jan 14, 2022

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Dec 30, 2021

Content of PR:

The build is finally green, but TBH I'm mindblown with the strangeness of errors. If anyone would like to solve them better, be my guests.

For the two last issues I've alse left comments in commits for future understanding of problems

@lchrusciel lchrusciel requested a review from a team as a code owner December 30, 2021 16:15
@lchrusciel lchrusciel force-pushed the fix-build branch 5 times, most recently from e0f47e6 to 0e31351 Compare January 12, 2022 16:00
@lchrusciel lchrusciel force-pushed the fix-build branch 2 times, most recently from 99789cb to 8fd1da6 Compare January 13, 2022 08:36
This change was the simplest scenario for single scecnario failing. This scenario was failing only in UI context(while working fine in API). The problem didn't exist when scenarios where run locally or just in separate step of GitHub Action. Instead of commiting more time for the investigation, I've decided to split the execution.
@GSadee GSadee merged commit ece9cde into Sylius:master Jan 14, 2022
@GSadee
Copy link
Member

GSadee commented Jan 14, 2022

Thank you, Łukasz! 🎉

@lchrusciel lchrusciel deleted the fix-build branch January 17, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants