Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] - Create migration container #859

Merged
merged 6 commits into from
Nov 15, 2022
Merged

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Oct 31, 2022

Flow Before

image

Flow After
image

@Ferror Ferror requested a review from a team as a code owner October 31, 2022 17:05
@probot-autolabeler probot-autolabeler bot added the Docker Docker-related issues and PRs. label Oct 31, 2022
@Ferror Ferror force-pushed the docker-migrations branch from e791fa3 to 57a9232 Compare October 31, 2022 17:35
docker-compose.prod.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@Ferror Ferror force-pushed the docker-migrations branch from 7e03262 to 3c06df7 Compare November 1, 2022 14:19
@Ferror Ferror requested a review from coldic3 November 1, 2022 14:20
@Ferror
Copy link
Contributor Author

Ferror commented Nov 1, 2022

PS. after this PR I will start working on the worker, cron, and migrations container to not have PHP-FPM. Those are going to be CLI-based containers

docker-compose.prod.yml Outdated Show resolved Hide resolved
@GSadee GSadee merged commit 4fe2ad4 into Sylius:1.12 Nov 15, 2022
@GSadee
Copy link
Member

GSadee commented Nov 15, 2022

Thank you, Zbigniew! 🎉

@Ferror Ferror deleted the docker-migrations branch November 15, 2022 14:11
lchrusciel added a commit that referenced this pull request Dec 7, 2022
… (Ferror)

This PR was merged into the 1.12 branch.

Discussion
----------

Wait for #859

Now we want each service to be waiting for migrations to end.

Commits
-------

6192af1 [docker] - Enable cron container to wait for migrations
21b1401 Merge branch \'1.12\' into docker-cron-fix
bc7685e Merge branch \'1.12\' into docker-cron-fix
windragon0910 added a commit to windragon0910/symfony_ecom_framework that referenced this pull request Oct 25, 2023
… (Ferror)

This PR was merged into the 1.12 branch.

Discussion
----------

Wait for Sylius/Sylius-Standard#859

Now we want each service to be waiting for migrations to end.

Commits
-------

6192af1eb9f39b21e9582c4c49a2bbf1cafc43e0 [docker] - Enable cron container to wait for migrations
21b1401501e021944fb15ba5f9940b058ae7b55e Merge branch \'1.12\' into docker-cron-fix
bc7685e237616268d134e7f728ef242288a4610e Merge branch \'1.12\' into docker-cron-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Docker-related issues and PRs. Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants