CS fixes

ecs.php

@@ -1,10 +1,8 @@
 <?php
 
 use PhpCsFixer\Fixer\ClassNotation\VisibilityRequiredFixer;
-use PhpCsFixer\Fixer\Comment\HeaderCommentFixer;
 use SlevomatCodingStandard\Sniffs\Commenting\InlineDocCommentDeclarationSniff;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
-use Symplify\CodingStandard\Fixer\Spacing\StandaloneLinePromotedPropertyFixer;
 use Symplify\EasyCodingStandard\ValueObject\Option;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
@@ -21,8 +19,6 @@
 //file that was distributed with this source code.',
 //    ]);
 
-    $containerConfigurator->services()->set(StandaloneLinePromotedPropertyFixer::class);
-
     $containerConfigurator->parameters()->set(Option::SKIP, [
         InlineDocCommentDeclarationSniff::class . '.MissingVariable',
         InlineDocCommentDeclarationSniff::class . '.NoAssignment',

src/Sylius/Bundle/ApiBundle/ApiPlatform/Factory/MergingExtractorResourceMetadataFactory.php

@@ -46,12 +46,10 @@ public function __construct(
     public function create(string $resourceClass): ResourceMetadata
     {
         $parentResourceMetadata = null;
-        if ($this->decorated) {
-            try {
-                $parentResourceMetadata = $this->decorated->create($resourceClass);
-            } catch (ResourceClassNotFoundException) {
-                // Ignore not found exception from decorated factories
-            }
+        try {
+            $parentResourceMetadata = $this->decorated->create($resourceClass);
+        } catch (ResourceClassNotFoundException) {
+            // Ignore not found exception from decorated factories
         }
 
         if (!(class_exists($resourceClass) || interface_exists($resourceClass)) || !$resource = $this->extractor->getResources()[$resourceClass] ?? false) {

src/Sylius/Bundle/ApiBundle/CommandHandler/Account/VerifyCustomerAccountHandler.php

@@ -23,9 +23,8 @@
 /** @experimental  */
 final class VerifyCustomerAccountHandler implements MessageHandlerInterface
 {
-    public function __construct(
-        private RepositoryInterface $shopUserRepository
-    ) {
+    public function __construct(private RepositoryInterface $shopUserRepository)
+    {
     }
 
     public function __invoke(VerifyCustomerAccount $command): JsonResponse

src/Sylius/Bundle/ApiBundle/Context/TokenBasedUserContext.php

@@ -19,9 +19,8 @@
 /** @experimental */
 final class TokenBasedUserContext implements UserContextInterface
 {
-    public function __construct(
-        private TokenStorageInterface $tokenStorage
-    ) {
+    public function __construct(private TokenStorageInterface $tokenStorage)
+    {
     }
 
     public function getUser(): ?UserInterface

src/Sylius/Bundle/ApiBundle/Controller/DeleteOrderItemAction.php

@@ -21,9 +21,8 @@
 
 final class DeleteOrderItemAction
 {
-    public function __construct(
-        private MessageBusInterface $commandBus
-    ) {
+    public function __construct(private MessageBusInterface $commandBus)
+    {
     }
 
     public function __invoke(Request $request): Response

src/Sylius/Bundle/ApiBundle/DataPersister/ShippingMethodDataPersister.php

@@ -21,9 +21,8 @@
 /** @experimental */
 final class ShippingMethodDataPersister implements ContextAwareDataPersisterInterface
 {
-    public function __construct(
-        private ContextAwareDataPersisterInterface $decoratedDataPersister
-    ) {
+    public function __construct(private ContextAwareDataPersisterInterface $decoratedDataPersister)
+    {
     }
 
     public function supports($data, array $context = []): bool

src/Sylius/Bundle/ApiBundle/DataProvider/OrderAdjustmentsSubresourceDataProvider.php

@@ -23,9 +23,8 @@
 /** @experimental */
 final class OrderAdjustmentsSubresourceDataProvider implements RestrictedDataProviderInterface, SubresourceDataProviderInterface
 {
-    public function __construct(
-        private OrderRepositoryInterface $orderRepository
-    ) {
+    public function __construct(private OrderRepositoryInterface $orderRepository)
+    {
     }
 
     public function supports(string $resourceClass, string $operationName = null, array $context = []): bool

src/Sylius/Bundle/ApiBundle/DataProvider/OrderItemAdjustmentsSubresourceDataProvider.php

@@ -23,9 +23,8 @@
 /** @experimental */
 final class OrderItemAdjustmentsSubresourceDataProvider implements RestrictedDataProviderInterface, SubresourceDataProviderInterface
 {
-    public function __construct(
-        private OrderItemRepositoryInterface $orderItemRepository
-    ) {
+    public function __construct(private OrderItemRepositoryInterface $orderItemRepository)
+    {
     }
 
     public function supports(string $resourceClass, string $operationName = null, array $context = []): bool

src/Sylius/Bundle/ApiBundle/DataTransformer/ChannelCodeAwareInputCommandDataTransformer.php

@@ -19,9 +19,8 @@
 /** @experimental */
 final class ChannelCodeAwareInputCommandDataTransformer implements CommandDataTransformerInterface
 {
-    public function __construct(
-        private ChannelContextInterface $channelContext
-    ) {
+    public function __construct(private ChannelContextInterface $channelContext)
+    {
     }
 
     public function transform($object, string $to, array $context = [])

src/Sylius/Bundle/ApiBundle/DataTransformer/LocaleCodeAwareInputCommandDataTransformer.php

@@ -19,9 +19,8 @@
 /** @experimental */
 final class LocaleCodeAwareInputCommandDataTransformer implements CommandDataTransformerInterface
 {
-    public function __construct(
-        private LocaleContextInterface $localeContext
-    ) {
+    public function __construct(private LocaleContextInterface $localeContext)
+    {
     }
 
     public function transform($object, string $to, array $context = [])

src/Sylius/Bundle/ApiBundle/DataTransformer/LoggedInCustomerEmailAwareCommandDataTransformer.php

@@ -23,9 +23,8 @@
 /** @experimental */
 final class LoggedInCustomerEmailAwareCommandDataTransformer implements CommandDataTransformerInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function transform($object, string $to, array $context = [])

src/Sylius/Bundle/ApiBundle/DataTransformer/LoggedInShopUserIdAwareCommandDataTransformer.php

@@ -21,9 +21,8 @@
 /** @experimental */
 final class LoggedInShopUserIdAwareCommandDataTransformer implements CommandDataTransformerInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     /**

src/Sylius/Bundle/ApiBundle/DataTransformer/SubresourceIdAwareCommandDataTransformer.php

@@ -20,9 +20,8 @@
 /** @experimental */
 final class SubresourceIdAwareCommandDataTransformer implements CommandDataTransformerInterface
 {
-    public function __construct(
-        private RequestStack $requestStack
-    ) {
+    public function __construct(private RequestStack $requestStack)
+    {
     }
 
     public function transform($object, string $to, array $context = [])

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/AcceptedProductReviewsExtension.php

@@ -21,9 +21,8 @@
 /** @experimental */
 final class AcceptedProductReviewsExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private string $productReviewClass
-    ) {
+    public function __construct(private string $productReviewClass)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/AddressesExtension.php

@@ -26,9 +26,8 @@
 /** @experimental */
 final class AddressesExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/CountryCollectionExtension.php

@@ -25,9 +25,8 @@
 /** @experimental */
 final class CountryCollectionExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/CurrencyCollectionExtension.php

@@ -25,9 +25,8 @@
 /** @experimental */
 final class CurrencyCollectionExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/HideArchivedShippingMethodExtension.php

@@ -20,9 +20,8 @@
 /** @experimental */
 final class HideArchivedShippingMethodExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private string $shippingMethodClass
-    ) {
+    public function __construct(private string $shippingMethodClass)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/LocaleCollectionExtension.php

@@ -25,9 +25,8 @@
 /** @experimental */
 final class LocaleCollectionExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/OrdersByLoggedInUserExtension.php

@@ -26,9 +26,8 @@
 /** @experimental */
 final class OrdersByLoggedInUserExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByChannelAndLocaleCodeExtension.php

@@ -24,9 +24,8 @@
 /** @experimental */
 final class ProductsByChannelAndLocaleCodeExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsWithEnableFlagExtension.php

@@ -22,9 +22,8 @@
 /** @experimental */
 final class ProductsWithEnableFlagExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/TaxonCollectionExtension.php

@@ -25,9 +25,8 @@
 /** @experimental */
 final class TaxonCollectionExtension implements ContextAwareQueryCollectionExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToCollection(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryItemExtension/AddressItemExtension.php

@@ -28,9 +28,8 @@
 /** @experimental */
 final class AddressItemExtension implements QueryItemExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToItem(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryItemExtension/OrderGetMethodItemExtension.php

@@ -28,9 +28,8 @@
 /** @experimental */
 final class OrderGetMethodItemExtension implements QueryItemExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToItem(

src/Sylius/Bundle/ApiBundle/Doctrine/QueryItemExtension/OrderMethodsItemExtension.php

@@ -27,9 +27,8 @@
 /** @experimental */
 final class OrderMethodsItemExtension implements QueryItemExtensionInterface
 {
-    public function __construct(
-        private UserContextInterface $userContext
-    ) {
+    public function __construct(private UserContextInterface $userContext)
+    {
     }
 
     public function applyToItem(

src/Sylius/Bundle/ApiBundle/Event/OrderCompleted.php

@@ -15,9 +15,12 @@
 
 class OrderCompleted
 {
-    public function __construct(
-        public string $orderToken
-    ) {
+    /** @var string */
+    public $orderToken;
+
+    public function __construct(string $orderToken)
+    {
+        $this->orderToken = $orderToken;
     }
 
     public function orderToken(): string

src/Sylius/Bundle/ApiBundle/EventHandler/OrderCompletedHandler.php

@@ -20,9 +20,8 @@
 /** @experimental */
 final class OrderCompletedHandler
 {
-    public function __construct(
-        private MessageBusInterface $commandBus
-    ) {
+    public function __construct(private MessageBusInterface $commandBus)
+    {
     }
 
     public function __invoke(OrderCompleted $orderCompleted): void

src/Sylius/Bundle/ApiBundle/EventListener/AuthenticationSuccessListener.php

@@ -20,9 +20,8 @@
 
 final class AuthenticationSuccessListener
 {
-    public function __construct(
-        private IriConverterInterface $iriConverter
-    ) {
+    public function __construct(private IriConverterInterface $iriConverter)
+    {
     }
 
     public function onAuthenticationSuccessResponse(AuthenticationSuccessEvent $event): void

src/Sylius/Bundle/ApiBundle/EventSubscriber/CatalogPromotionEventSubscriber.php

@@ -23,9 +23,8 @@
 
 final class CatalogPromotionEventSubscriber implements EventSubscriberInterface
 {
-    public function __construct(
-        private CatalogPromotionAnnouncerInterface $catalogPromotionAnnouncer
-    ) {
+    public function __construct(private CatalogPromotionAnnouncerInterface $catalogPromotionAnnouncer)
+    {
     }
 
     public static function getSubscribedEvents(): array

src/Sylius/Bundle/ApiBundle/EventSubscriber/ProductSlugEventSubscriber.php

@@ -25,9 +25,8 @@
 /** @experimental */
 final class ProductSlugEventSubscriber implements EventSubscriberInterface
 {
-    public function __construct(
-        private SlugGeneratorInterface $slugGenerator
-    ) {
+    public function __construct(private SlugGeneratorInterface $slugGenerator)
+    {
     }
 
     public static function getSubscribedEvents(): array