[RFC] [UPGRADE] Split API and non API upgrade files #12831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
added
Enhancement
probot-autolabeler
bot
added
the
Maintenance
stloyd
reviewed
Jul 22, 2021
| @@ -1,12 +1,3 @@ | |||
| # UPGRADE FROM `v1.10.0` TO `v1.10.1` | |||
|
|
|||
| 1. API is disabled by default, to enable it you need to set flag to ``true`` in ``app/config/packages/_sylius.yaml``: | |||
There was a problem hiding this comment.
This should be left here IMHO as it's big BC break and should be widely visible.
GSadee
approved these changes
Jul 22, 2021
This was referenced Jul 23, 2021
GSadee
added a commit
that referenced
this pull request
Jul 26, 2021
…ciel) This PR was merged into the 1.8 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Split from #12831 | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 8a7df3c [UPGRADE] Split API and non API upgrade files
GSadee
added a commit
that referenced
this pull request
Jul 26, 2021
…ciel) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Split from #12831 | License | MIT Commits ------- 54f1204 [UPGRADE] Split API and non API upgrade files
GSadee
added a commit
that referenced
this pull request
Jul 26, 2021
…ciel) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Split from #12831 | License | MIT Commits ------- a98f92f [UPGRADE] Split API and non API upgrade files
GSadee
added a commit
that referenced
this pull request
Jul 27, 2021
This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Split from #12831 | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- c9f5d2c [UPGRADE] Split API and non API upgrade files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea came from our slack and I thought it may make sense. I'm proposing a split of upgrade files, as most people do not have to care about our API changes at the moment.