Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource movement sort persistance #4164

Merged

Conversation

nakashu
Copy link
Contributor

@nakashu nakashu commented Feb 15, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

ResourceController was missing update event and flush for move actions. Consequently resources order/sorting wasn't changed. (promotions priority)

@nakashu
Copy link
Contributor Author

nakashu commented Feb 15, 2016

travis errors seems unrelated - some CRUD connection errors.

@nakashu nakashu force-pushed the fix/resource-movement-sort-persistance branch from 8176283 to e294ff6 Compare February 16, 2016 00:00
@pjedrzejewski
Copy link
Member

@nakashu I have restarted the build. 👍

@nakashu nakashu changed the title Fix/resource movement sort persistance Resource movement sort persistance Feb 16, 2016
@nakashu
Copy link
Contributor Author

nakashu commented Feb 16, 2016

hmm. its 3rd time it failed with the same errors. that's weird. any ideas ?

@nakashu nakashu force-pushed the fix/resource-movement-sort-persistance branch 2 times, most recently from dd4591c to 6d77671 Compare February 19, 2016 21:30
@nakashu nakashu force-pushed the fix/resource-movement-sort-persistance branch from 6d77671 to 3381ea2 Compare March 8, 2016 21:52
@nakashu
Copy link
Contributor Author

nakashu commented Mar 8, 2016

yay test have passed .. bump

pjedrzejewski pushed a commit that referenced this pull request Mar 8, 2016
…istance

Resource movement sort persistance
@pjedrzejewski pjedrzejewski merged commit f487bbd into Sylius:master Mar 8, 2016
@pjedrzejewski
Copy link
Member

Thanks @nakashu! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants