[Order] ShipmentProcessor renaming #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
the
Enhancement
lchrusciel
force-pushed
the
renaming-shipment-processor
branch
from
b098b8d to
fccb000
Compare
lchrusciel
changed the title
| @@ -68,7 +68,7 @@ public function __construct(OrderShipmentFactoryInterface $shipmentFactory, Ship | |||
| */ | |||
| public function processOrderShipments(GenericEvent $event) | |||
| { | |||
| $this->shipmentFactory->createForOrder( | |||
| $this->shipmentFactory->processOrderShipment( | |||
| $this->getOrder($event) | |||
There was a problem hiding this comment.
This will fit one line :)
lchrusciel
changed the title
| $this->shouldImplement(ShipmentProcessorInterface::class); | ||
| } | ||
|
|
||
| function it_creates_a_single_shipment_and_assigns_all_unit_units_to_it( |
There was a problem hiding this comment.
...all_unit_units... ?
lchrusciel
force-pushed
the
renaming-shipment-processor
branch
2 times, most recently
from
2277298 to
5815dee
Compare
lchrusciel
force-pushed
the
renaming-shipment-processor
branch
from
5815dee to
a9279c3
Compare
|
👍 |
lchrusciel
changed the title
pjedrzejewski
pushed a commit
that referenced
this pull request
Mar 1, 2016
[Order] ShipmentProcessor renaming
|
Thanks Łukasz! |
|
Hi, For consistency, just need to rename the parameter too. <parameter key="sylius.order_processing.shipment_factory.class">Sylius\Component\Core\OrderProcessing\OrderShipmentProcessor</parameter>into <parameter key="sylius.order_processing.shipment_processor.class">Sylius\Component\Core\OrderProcessing\OrderShipmentProcessor</parameter> |
|
@Niiko good catch. I have missed it totally. |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…essor [Order] ShipmentProcessor renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderShipmentFactory is not a factory for sure. I'v renamed it to ShipmentProcessor because of lack of better name. Any suggestion are welcome.
Update: Name has been changed to OrderShipmentProcessor