[Behat][Promotion] Fixed discount on items in price range #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
changed the title
| And it gives "€30.00" off on every product classified as "Mugs" | ||
| When I add 2 products "PHP Mug" to the cart | ||
| Then theirs price should be decreased by "€40.00" | ||
| Then my cart total should be "€0.00" |
There was a problem hiding this comment.
👍 but this is bug in scenario from here and I'm gonna fix it there ;)
| * | ||
| * @return bool | ||
| */ | ||
| private function isInvalidConfiguration(array $configuration) |
There was a problem hiding this comment.
Maybe better name isConfigured?
Zales0123
force-pushed
the
fixed-discount-on-items-in-range
branch
from
bda5a4e to
c5ecc2e
Compare
| ->filter([$item1, $item2, $item3], ['filters' => ['price_range' => ['min' => 1000, 'max' => 10000]]]) | ||
| ->shouldReturn([$item2]) | ||
| ; | ||
| } |
There was a problem hiding this comment.
How about edge cases? How does it work for items priced at 1000 or 10000?
Zales0123
force-pushed
the
fixed-discount-on-items-in-range
branch
2 times, most recently
from
1cb3a74 to
836f2dd
Compare
| ->filter([$item1, $item2], ['filters' => ['price_range' => ['min' => 1000, 'max' => 10000]]]) | ||
| ->shouldReturn([$item2]) | ||
| ; | ||
| } |
There was a problem hiding this comment.
How about the cases where only min is specified in the configuration? I see logic for that, but don't see any specs covering it...
Btw. what will happen if I will only specify the max in the config? It looks like there will be some unwanted result 💥
Zales0123
force-pushed
the
fixed-discount-on-items-in-range
branch
from
836f2dd to
466b2d9
Compare
|
👍 |
pjedrzejewski
pushed a commit
that referenced
this pull request
Mar 17, 2016
[Behat][Promotion] Fixed discount on items in price range
|
Thank you Mateusz! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…-in-range [Behat][Promotion] Fixed discount on items in price range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4391 and #4453, highly recommend to wait with merge for everybody good health ;)