[GridBundle] [WIP] PHPCR-ODM Driver #4813
Conversation
| */ | ||
| public function like($field, $pattern) | ||
| { | ||
| return $this->expressionBuilder->contains($field, $pattern); |
There was a problem hiding this comment.
"like" doesn't exist in the Collections QB API, bu we can actually return a custom comparison as new Comparison($field, 'like', $pattern), same with notLike.
There was a problem hiding this comment.
like is analasgous to contains if I understand correctly (it is referenced to as "contains" in the filter).
| public function isNotNull($field) | ||
| { | ||
| throw new \BadMethodCallException('Not currently supported.'); | ||
| return $this->expressionBuilder->isNull($field); |
There was a problem hiding this comment.
This line should be removed if we throw exception above.
|
Hey @dantleech, thanks for this contribution! If it is really not possible to use PHPCR query builder directly, then this sounds like a smart workaround. I'd say go for it. It does not make sense to add specs for existing code, so spec only new stuff or code that does not work as expected. :) |
|
Updated, we can now build the query for PHPCR-ODM fom the Doctrine Collection Expressions. I added the test for this with PHPUnit (it is more of a light-weight functional test) and created a simple helper class to generate a string representation of the query builder state (to make testing easier). Next steps would be to add specs for the other classes and finish this off. |
pjedrzejewski
changed the title
|
Hey @dantleech, we are going to need this real soon, so I will be happy to help with finishing this. Do you have some time? :) |
|
hey @pjedrzejewski , yeah I can work on it tomorrow. I was waiting on #4812 |
|
Updated, all of the expressions are supported now and manually testing it seems to work fine for the String and Boolean filters. Still some work to do however. |
| */ | ||
| public function comparison($field, $operator, $value) | ||
| { | ||
| throw new \BadMethodCallException('Not supported yet.'); |
There was a problem hiding this comment.
@pjedrzejewski when does this get used?
There was a problem hiding this comment.
Nowhere yet, but I wanted to have it on the interface. Let's keep it for now like for other drivers.
| public function isNull($field) | ||
| { | ||
| // could probably do this by comparing with eq = NULL and handling this case | ||
| // in the visitor. |
dantleech
force-pushed
the
phpcrodm_driver
branch
2 times, most recently
from
817312e to
806fbda
Compare
| /** | ||
| * @param QueryBuilder $queryBuilder | ||
| */ | ||
| function __construct(QueryBuilder $queryBuilder, ExpressionBuilder $expressionBuilder = null) |
| </parameters> | ||
|
|
||
| <services> | ||
| <service id="sylius.grid_driver.doctrine.orm" class="%sylius.grid_driver.doctrine.phpcrodm.class%"> |
dantleech
force-pushed
the
phpcrodm_driver
branch
2 times, most recently
from
1df1aba to
7be50d9
Compare
| return $node; | ||
| } | ||
|
|
||
| public function dispatch(Expression $expr, $parentNode = null) |
dantleech
force-pushed
the
phpcrodm_driver
branch
2 times, most recently
from
9d3e8c1 to
37c1eee
Compare
dantleech
force-pushed
the
phpcrodm_driver
branch
from
37c1eee to
0b15d86
Compare
|
Updated -- implemented order by - so that should be the final nail in this PR from a feature POV. One thing I didn't find out how to test was ordering the grid from the UI - I notice that in the docs there is a |
|
Awesome work, this is a huge help for us, as we will soon add PHPCR stuff to new admin. Thank you Dan! 👍 We will absolutely iterate on this in separate PRs. Regarding your question, sorting is not yet that functional, I will be looking at it soon for the UI and ORM driver. I have one question though: why we need to apply sorting in the DataSource and not inside of the ExpressionBuilder? |
|
Thanks :)
The expression builder is just a factory for I just store it in the ExpressionBuilder itself, and we can then later apply it to the actual |
This PR would introduce a PHPCR-ODM driver.
The main problem is building the query builder - the PHPCR-ODM query builder uses a different design than that of the standard Doctrine Query Builder, which makes building the query more difficult.
In order to solve this this PR uses the Doctrine Commons expresion builder and implements a visitor for that to build the PHPCR-ODM query.
If this approach seems reasonable I will finish this off and add the tests (PHPSpec or PHPUnit?)