[Shop] Sign in and registration feature #5073
Conversation
Arminek
commented
May 20, 2016
•
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Related tickets | #4939 |
| License | MIT |
Arminek
changed the title
Arminek
force-pushed
the
new-shop-sign-in
branch
2 times, most recently
from
1e8ce3e to
2a57b1e
Compare
| @customer_account | ||
| Feature: Account registration | ||
| In order to order products | ||
| As a visitor |
[Behat] Add login page and account context [Shop][Security] create shop firewall [Behat][Shop] Registering, reseting password features
| */ | ||
| public function checkValidationMessageFor($element, $message) | ||
| { | ||
| $foundedElement = $this->getFieldElement($element); |
Arminek
force-pushed
the
new-shop-sign-in
branch
2 times, most recently
from
bd54338 to
b9a0fd3
Compare
|
OK, I looked at the code and I think we should separate the login and register from "account". Account should be only for stuff in "My account" section = change of password, profile edit, order history and address book. Login and register should be separate context and different level of pages: `````` sylius.behat.page.shop.login WDYT? Maybe LoginContext and RegistrationContext? |
| { | ||
| $resolver->setDefaults([ | ||
| 'data_class' => $this->dataClass, | ||
| 'validation_groups' => $this->validationGroups, |
There was a problem hiding this comment.
I am not sure about this change WDYT @pjedrzejewski ?
There was a problem hiding this comment.
What do you need to override here exactly? Not perfect, but would be better to call parent::configureOptions, otherwise we do not even know what you change unless we check parent method. Added cascade_validation? Why you need it?
Arminek
force-pushed
the
new-shop-sign-in
branch
3 times, most recently
from
680f671 to
4c17307
Compare
|
Nice work Arek, thanks! |
[Shop] Sign in and registration feature
