Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coupon generation fix #5087

Merged
merged 1 commit into from
May 23, 2016
Merged

Coupon generation fix #5087

merged 1 commit into from
May 23, 2016

Conversation

lchrusciel
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets mentioned in comment
License MIT

@pamil
Copy link
Contributor

pamil commented May 23, 2016 •
edited
Loading

This way memory taken by generated codes will never be freed until the process dies (or when next generation occurs). We can remove $this->generatedCoupons property and pass a local variable as an argument to the other functions without affecting the performance.

@pjedrzejewski
Copy link
Member

@pamil 👍 , but in a separate PR.

@lchrusciel lchrusciel mentioned this pull request May 23, 2016
Merged
@pjedrzejewski pjedrzejewski merged commit 4c527fe into Sylius:master May 23, 2016
@pjedrzejewski
Copy link
Member

Thanks Łukasz! /cc @peteward I will retag v0.18.0 so that it includes this. :)

@peteward
Copy link

Thanks for the quick turnaround on this guys! 👍

@lchrusciel lchrusciel deleted the coupon-generation-fix branch May 23, 2016 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lchrusciel @pamil @pjedrzejewski @peteward