[Core] Implement simple ShopperContext #5196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
New Feature
DX
pjedrzejewski
force-pushed
the
experimental/shopper-context
branch
from
802d152 to
ca7005c
Compare
3 tasks
| public function getLocaleCode(); | ||
|
|
||
| /** | ||
| * @return CustomerInterface |
There was a problem hiding this comment.
CustomerInterface|null
pjedrzejewski
force-pushed
the
experimental/shopper-context
branch
from
ca7005c to
a931d54
Compare
| /** | ||
| * @author Paweł Jędrzejewski <[email protected]> | ||
| */ | ||
| interface ShopperContextInterface |
There was a problem hiding this comment.
What do you think about normalizing methods in current interfaces (one has getCurrentX(), the other one - getX()) and then just extending them here?
There was a problem hiding this comment.
@pamil I think it could be good, but let's leave that for a separate PR, we definitely need to normalize methods on all these contexts.
|
Nice! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…r-context [Core] Implement simple ShopperContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All services, form types, etc. should be stateless, but sometimes we need to have access (in routing, or other contexts) to currently active channel, currency, locale and customer. This service simplifies this and I have also added this info to the web debug toolbar. So as a developer, you can always check the currently selected context.
This is the first step to clean up all the contexts together and unify their behavior and usage.