Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat][Shop] Seeing shipping details on order summary #5265

Merged
merged 3 commits into from
Jun 22, 2016
Merged

[Behat][Shop] Seeing shipping details on order summary #5265

merged 3 commits into from
Jun 22, 2016

Conversation

Zales0123
Copy link
Member

@Zales0123 Zales0123 commented Jun 15, 2016 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets
License MIT

Based on #5240

@pjedrzejewski pjedrzejewski added the Shop ShopBundle related issues and PRs. label Jun 15, 2016
@Zales0123 Zales0123 force-pushed the seeing-shipping-details-on-order-summary branch from 0db0b62 to cab36bd Compare June 16, 2016 08:27
@Zales0123 Zales0123 mentioned this pull request Jun 16, 2016
Closed
@Zales0123 Zales0123 force-pushed the seeing-shipping-details-on-order-summary branch 2 times, most recently from 321e9b7 to 90ebbbd Compare June 16, 2016 12:22
GSadee
GSadee reviewed Jun 16, 2016
View reviewed changes
features/checkout/seeing_order_summary/seeing_addresses_on_order_summary_page.feature
@@ -0,0 +1,33 @@
@checkout
Feature: Seeing order addresses on order summary page
In order be certain about shipping and bulling address
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to be certain about shipping and billing address

@Zales0123 Zales0123 force-pushed the seeing-shipping-details-on-order-summary branch 3 times, most recently from 9bf8a58 to 63dc9e2 Compare June 21, 2016 09:33
@Zales0123 Zales0123 force-pushed the seeing-shipping-details-on-order-summary branch 2 times, most recently from f574da9 to b23907a Compare June 21, 2016 11:16
@Zales0123 Zales0123 changed the title [WIP][Behat][Shop] Seeing shipping details on order summary [Behat][Shop] Seeing shipping details on order summary Jun 21, 2016
@tuka217 tuka217 mentioned this pull request Jun 21, 2016
Closed
pjedrzejewski
pjedrzejewski reviewed Jun 21, 2016
View reviewed changes
features/checkout/seeing_order_summary/seeing_addresses_on_order_summary_page.feature
And I complete the addressing step
And I complete order with "Free" shipping method and "Offline" payment
Then I should be on the checkout summary step
And I should see this shipping address as shipping address
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks quite confusing 😄 This step should check if typed shipping address is displayed on summary page... How do you think it should be written? And I should see typed shipping address as shipping address on order summary page? And I should see typed shipping address on order summary page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong with I should see this shipping address on order summary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should see this shipping address And I should see this billing address. WDYT?

@Zales0123 Zales0123 force-pushed the seeing-shipping-details-on-order-summary branch from b23907a to e65cdb5 Compare June 22, 2016 07:40
michalmarcinkowski
michalmarcinkowski reviewed Jun 22, 2016
View reviewed changes
features/checkout/seeing_order_summary/seeing_addresses_on_order_summary_page.feature
@ui
Scenario: Seeing the same shipping and billing address on order summary
Given I have product "Lannister Coat" in the cart
When I specified the shipping address as "Ankh Morpork", "Frost Alley", "90210", "France" for "Jon Snow"
Copy link
Contributor

@michalmarcinkowski michalmarcinkowski Jun 22, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I specify ... or Given I specified ....

@tuka217 tuka217 mentioned this pull request Jun 22, 2016
Merged
@Zales0123 Zales0123 force-pushed the seeing-shipping-details-on-order-summary branch from e65cdb5 to 9d44bbe Compare June 22, 2016 11:57
@pjedrzejewski pjedrzejewski merged commit 92fad8a into Sylius:master Jun 22, 2016
@pjedrzejewski
Copy link
Member

Thanks Mateusz!

@Zales0123 Zales0123 deleted the seeing-shipping-details-on-order-summary branch October 6, 2016 20:34
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Merge pull request Sylius#5265 from Zales0123/seeing-shipping-details…
a4862f8 
…-on-order-summary

[Behat][Shop] Seeing shipping details on order summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Shop ShopBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zales0123 @pjedrzejewski @GSadee @Arminek @michalmarcinkowski @tuka217